Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2157)

Issue 2350233002: Reland of Run SVGs through nanobench on all Perf bots (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Run SVGs through nanobench on all Perf bots (patchset #1 id:1 of https://codereview.chromium.org/2348563003/ ) Reason for revert: skbug/5770 has been fixed. Trying out trybots to see if this can be relanded. Original issue's description: > Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 of https://codereview.chromium.org/2343903002/ ) > > Reason for revert: > Causing failures: > https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812 > > Original issue's description: > > Run SVGs through nanobench on all Perf bots. > > > > Tested with: > > python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001 > > > > Example output is here: > > https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410 > > Nanobench did run on SVGs. > > > > BUG=skia:5757 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002 > > > > Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52 > > TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:5757 > > Committed: https://skia.googlesource.com/skia/+/be7e3c0db3caa7a86ae233a6bd26281817b83882 TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350233002 Committed: https://skia.googlesource.com/skia/+/304e6745dc5ee8a866c84a12d9c710438389b3b3

Patch Set 1 : Initial patch #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M infra/bots/recipes/swarm_perf.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-GN_Android_Vulkan.json View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus5-GPU-Adreno330-arm-Debug-GN_Android.json View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus6-GPU-Adreno420-arm-Release-GN_Android.json View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-GN_Android.json View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-GN_Android.json View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 2 chunks +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 chunk +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/recipe_with_gerrit_patch.json View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rmistry
Created Reland of un SVGs through nanobench on all Perf bots
4 years, 3 months ago (2016-09-19 18:33:06 UTC) #1
rmistry
On 2016/09/19 18:33:06, rmistry wrote: > Created Reland of un SVGs through nanobench on all ...
4 years, 3 months ago (2016-09-19 18:50:53 UTC) #3
f(malita)
lgtm
4 years, 3 months ago (2016-09-19 18:52:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350233002/270001
4 years, 3 months ago (2016-09-19 20:12:30 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 20:44:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:270001) as
https://skia.googlesource.com/skia/+/304e6745dc5ee8a866c84a12d9c710438389b3b3

Powered by Google App Engine
This is Rietveld 408576698