Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: src/deoptimizer.cc

Issue 23502004: Implement materialization support for JSArray types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1678 matching lines...) Expand 10 before | Expand all | Expand 10 after
1689 materialization_value_index_ += kDoubleSize / kPointerSize - 1; 1689 materialization_value_index_ += kDoubleSize / kPointerSize - 1;
1690 break; 1690 break;
1691 } 1691 }
1692 case JS_OBJECT_TYPE: { 1692 case JS_OBJECT_TYPE: {
1693 Handle<JSObject> object = 1693 Handle<JSObject> object =
1694 isolate_->factory()->NewJSObjectFromMap(map, NOT_TENURED, false); 1694 isolate_->factory()->NewJSObjectFromMap(map, NOT_TENURED, false);
1695 materialized_objects_->Add(object); 1695 materialized_objects_->Add(object);
1696 Handle<Object> properties = MaterializeNextValue(); 1696 Handle<Object> properties = MaterializeNextValue();
1697 Handle<Object> elements = MaterializeNextValue(); 1697 Handle<Object> elements = MaterializeNextValue();
1698 object->set_properties(FixedArray::cast(*properties)); 1698 object->set_properties(FixedArray::cast(*properties));
1699 object->set_elements(FixedArray::cast(*elements)); 1699 object->set_elements(FixedArrayBase::cast(*elements));
1700 for (int i = 0; i < length - 3; ++i) { 1700 for (int i = 0; i < length - 3; ++i) {
1701 Handle<Object> value = MaterializeNextValue(); 1701 Handle<Object> value = MaterializeNextValue();
1702 object->FastPropertyAtPut(i, *value); 1702 object->FastPropertyAtPut(i, *value);
1703 } 1703 }
1704 break; 1704 break;
1705 } 1705 }
1706 case JS_ARRAY_TYPE: {
1707 Handle<JSArray> object =
1708 isolate_->factory()->NewJSArray(0, map->elements_kind());
1709 materialized_objects_->Add(object);
1710 Handle<Object> properties = MaterializeNextValue();
1711 Handle<Object> elements = MaterializeNextValue();
1712 Handle<Object> length = MaterializeNextValue();
1713 object->set_properties(FixedArray::cast(*properties));
1714 object->set_elements(FixedArrayBase::cast(*elements));
1715 object->set_length(*length);
1716 break;
1717 }
1706 default: 1718 default:
1707 PrintF("[couldn't handle instance type %d]\n", map->instance_type()); 1719 PrintF("[couldn't handle instance type %d]\n", map->instance_type());
1708 UNREACHABLE(); 1720 UNREACHABLE();
1709 } 1721 }
1710 } 1722 }
1711 1723
1712 return materialized_objects_->at(object_index); 1724 return materialized_objects_->at(object_index);
1713 } 1725 }
1714 1726
1715 1727
(...skipping 1593 matching lines...) Expand 10 before | Expand all | Expand 10 after
3309 3321
3310 void DeoptimizedFrameInfo::Iterate(ObjectVisitor* v) { 3322 void DeoptimizedFrameInfo::Iterate(ObjectVisitor* v) {
3311 v->VisitPointer(BitCast<Object**>(&function_)); 3323 v->VisitPointer(BitCast<Object**>(&function_));
3312 v->VisitPointers(parameters_, parameters_ + parameters_count_); 3324 v->VisitPointers(parameters_, parameters_ + parameters_count_);
3313 v->VisitPointers(expression_stack_, expression_stack_ + expression_count_); 3325 v->VisitPointers(expression_stack_, expression_stack_ + expression_count_);
3314 } 3326 }
3315 3327
3316 #endif // ENABLE_DEBUGGER_SUPPORT 3328 #endif // ENABLE_DEBUGGER_SUPPORT
3317 3329
3318 } } // namespace v8::internal 3330 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698