|
|
Description[HttpCache] Add cache metrics for audio/video behavior
Cleans up the content-type metrics in http_cache_transaction and adds metrics
for two new content types, audio and video.
BUG=617620
Committed: https://crrev.com/81c04644f176ac5873c84db8f1cc8193762f88f3
Cr-Commit-Position: refs/heads/master@{#420661}
Patch Set 1 #
Total comments: 3
Depends on Patchset: Messages
Total messages: 25 (11 generated)
The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jkarlin@chromium.org changed reviewers: + gavinp@chromium.org, rkaplow@chromium.org
gavinp@ PTAL at everything rkaplow@ PTAL at histograms.xml Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Thanks rkaplow. gavinp@ PTAL, thanks!
gavinp@ PTAL, thank you.
gavinp@ Ping!
lgtm. That macro was a bit overdue. Thanks. https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); Does this have to be "", or would () work too? I believe "", right?
lgtm. That macro was a bit overdue. Thanks. https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); Does this have to be "", or would () work too? I believe "", right?
Thanks! https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); On 2016/09/23 15:41:49, gavinp wrote: > Does this have to be "", or would () work too? I believe "", right? > () works. WIll commit with that.
The CQ bit was checked by jkarlin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gavinp@chromium.org, rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2350183002/#ps20001 (title: "macro nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transac... net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); On 2016/09/23 15:53:02, jkarlin wrote: > On 2016/09/23 15:41:49, gavinp wrote: > > Does this have to be "", or would () work too? I believe "", right? > > > > () works. WIll commit with that. Nope, Windows doesn't like it. Reverting.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by jkarlin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [HttpCache] Add cache metrics for audio/video behavior Cleans up the content-type metrics in http_cache_transaction and adds metrics for two new content types, audio and video. BUG=617620 ========== to ========== [HttpCache] Add cache metrics for audio/video behavior Cleans up the content-type metrics in http_cache_transaction and adds metrics for two new content types, audio and video. BUG=617620 Committed: https://crrev.com/81c04644f176ac5873c84db8f1cc8193762f88f3 Cr-Commit-Position: refs/heads/master@{#420661} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/81c04644f176ac5873c84db8f1cc8193762f88f3 Cr-Commit-Position: refs/heads/master@{#420661} |