Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2350183002: [HttpCache] Add cache metrics for audio/video behavior (Closed)

Created:
4 years, 3 months ago by jkarlin
Modified:
4 years, 3 months ago
Reviewers:
gavinp, rkaplow
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, asvitkine+watch_chromium.org, kinuko+cache_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HttpCache] Add cache metrics for audio/video behavior Cleans up the content-type metrics in http_cache_transaction and adds metrics for two new content types, audio and video. BUG=617620 Committed: https://crrev.com/81c04644f176ac5873c84db8f1cc8193762f88f3 Cr-Commit-Position: refs/heads/master@{#420661}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -104 lines) Patch
M net/http/http_cache_transaction.cc View 3 chunks +30 lines, -104 lines 3 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (11 generated)
jkarlin
gavinp@ PTAL at everything rkaplow@ PTAL at histograms.xml Thanks!
4 years, 3 months ago (2016-09-19 17:04:26 UTC) #4
rkaplow
lgtm
4 years, 3 months ago (2016-09-19 18:23:03 UTC) #7
jkarlin
Thanks rkaplow. gavinp@ PTAL, thanks!
4 years, 3 months ago (2016-09-19 18:48:59 UTC) #8
jkarlin
gavinp@ PTAL, thank you.
4 years, 3 months ago (2016-09-22 15:25:09 UTC) #9
jkarlin
gavinp@ Ping!
4 years, 3 months ago (2016-09-23 14:19:41 UTC) #10
gavinp
lgtm. That macro was a bit overdue. Thanks. https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc#newcode2873 net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); ...
4 years, 3 months ago (2016-09-23 15:41:48 UTC) #11
gavinp
lgtm. That macro was a bit overdue. Thanks. https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc#newcode2873 net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); ...
4 years, 3 months ago (2016-09-23 15:41:49 UTC) #12
jkarlin
Thanks! https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc#newcode2873 net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); On 2016/09/23 15:41:49, gavinp wrote: > Does ...
4 years, 3 months ago (2016-09-23 15:53:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350183002/20001
4 years, 3 months ago (2016-09-23 15:54:30 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/263112)
4 years, 3 months ago (2016-09-23 16:45:01 UTC) #18
jkarlin
https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (right): https://codereview.chromium.org/2350183002/diff/1/net/http/http_cache_transaction.cc#newcode2873 net/http/http_cache_transaction.cc:2873: CACHE_STATUS_HISTOGRAMS(""); On 2016/09/23 15:53:02, jkarlin wrote: > On 2016/09/23 ...
4 years, 3 months ago (2016-09-23 17:05:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350183002/1
4 years, 3 months ago (2016-09-23 17:06:07 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 18:09:25 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:11:49 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81c04644f176ac5873c84db8f1cc8193762f88f3
Cr-Commit-Position: refs/heads/master@{#420661}

Powered by Google App Engine
This is Rietveld 408576698