Index: net/quic/core/quic_server_session_base_test.cc |
diff --git a/net/quic/core/quic_server_session_base_test.cc b/net/quic/core/quic_server_session_base_test.cc |
index d0a6cc50c43266adde9824e3095e057dfc521ad6..f52046b165df0aa2a4ade413cdda7167d7062f31 100644 |
--- a/net/quic/core/quic_server_session_base_test.cc |
+++ b/net/quic/core/quic_server_session_base_test.cc |
@@ -185,13 +185,18 @@ INSTANTIATE_TEST_CASE_P(Tests, |
::testing::ValuesIn(AllSupportedVersions())); |
TEST_P(QuicServerSessionBaseTest, ServerPushDisabledByDefault) { |
+ FLAGS_quic_enable_server_push_by_default = true; |
// Without the client explicitly sending kSPSH, server push will be disabled |
- // at the server. |
+ // at the server, until version 35 when it is enabled by default. |
EXPECT_FALSE( |
session_->config()->HasReceivedConnectionOptions() && |
ContainsQuicTag(session_->config()->ReceivedConnectionOptions(), kSPSH)); |
session_->OnConfigNegotiated(); |
- EXPECT_FALSE(session_->server_push_enabled()); |
+ if (GetParam() <= QUIC_VERSION_34) { |
+ EXPECT_FALSE(session_->server_push_enabled()); |
+ } else { |
+ EXPECT_TRUE(session_->server_push_enabled()); |
+ } |
} |
TEST_P(QuicServerSessionBaseTest, CloseStreamDueToReset) { |
@@ -342,7 +347,11 @@ TEST_P(QuicServerSessionBaseTest, MaxAvailableStreams) { |
session_.get(), kLimitingStreamId + 4)); |
} |
+// TODO(ckrasic): remove this when |
+// FLAGS_quic_enable_server_push_by_default is |
+// deprecated. |
TEST_P(QuicServerSessionBaseTest, EnableServerPushThroughConnectionOption) { |
+ FLAGS_quic_enable_server_push_by_default = false; |
// Assume server received server push connection option. |
QuicTagVector copt; |
copt.push_back(kSPSH); |