third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp - Issue 2350163002: Prevent LayoutTest setting -1 page scale factor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp

Issue 2350163002: Prevent LayoutTest setting -1 page scale factor. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp

diff --git a/third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp b/third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp

index 563265425618c79fd7cd3fe92aaa2ac57e97bdb5..8494f7d9bfacc9e5f498e978f81ab598c0509c58 100644

--- a/third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp

+++ b/third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp

@@ -58,8 +58,6 @@ void PageScaleConstraints::overrideWith(const PageScaleConstraints& other)

float PageScaleConstraints::clampToConstraints(float pageScaleFactor) const

{

- if (pageScaleFactor == -1)

- return pageScaleFactor;

if (minimumScale != -1)

pageScaleFactor = std::max(pageScaleFactor, minimumScale);

if (maximumScale != -1)