third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-invalid-page-scale-factor.html - Issue 2350163002: Prevent LayoutTest setting -1 page scale factor.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-invalid-page-scale-factor.html

Issue 2350163002: Prevent LayoutTest setting -1 page scale factor. (Closed)

Patch Set: Rewrite the test. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 body {

	6 height: 2000px;

	7 width: 2000px;

	8 }

	9 </style>

	10 <script>

	11 function run()

	12 {

	13 window.internals.setPageScaleFactor(-1);

	14 if (window.testRunner) {

	15 testRunner.capturePixelsAsyncThen(function() {});

	16 testRunner.waitUntilDone();

	17 window.setTimeout(notifyDone, 1200);
	ajuma 2016/09/19 18:58:57 Using setTimeout can make tests flaky, so using re Using setTimeout can make tests flaky, so using requestAnimationFrame is preferred.
	18 }

	19 }

	20 function notifyDone()

	21 {

	22 testRunner.notifyDone();

	23 }

	24 </script>

	25 </head>

	26 <body onload="run()">

	27 <div id="description">

	28 The test passes if the page does not crash.

	29 </div>

	30 </body>

	31 </html>

OLD	NEW