third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-invalid-page-scale-factor.html - Issue 2350163002: Prevent LayoutTest setting -1 page scale factor.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-invalid-page-scale-factor.html

Issue 2350163002: Prevent LayoutTest setting -1 page scale factor. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <style>

	4 body {

	5 height: 2000px;

	6 width: 2000px;

	7 }

	8 ::-webkit-scrollbar {
	ajuma 2016/09/19 17:37:39 Is this part needed? Is this part needed? sunxd 2016/09/19 18:54:32 Done. Show quoted text On 2016/09/19 17:37:39, ajuma wrote: > Is this part needed? Done.
	9 width: 0px;

	10 height: 0px;

	11 }

	12 </style>

	13

	14 <script>

	15 function viewport() {

	16 return window.visualViewport;
	ajuma 2016/09/19 17:37:39 This seems unused. This seems unused. sunxd 2016/09/19 18:54:32 Done. Show quoted text On 2016/09/19 17:37:39, ajuma wrote: > This seems unused. Done.
	17 }

	18

	19 window.internals.setPageScaleFactor(-1);

	20

	21 window.onload = function() {

	22 if (window.testRunner)

	23 window.testRunner.capturePixelsAsyncThen(function() {});
	ajuma 2016/09/19 17:37:39 Would it work to set this up in the waitUntilDone/ Would it work to set this up in the waitUntilDone/notifyDone style that many layout tests use? e.g. set the page scale factor, then register a requestAnimationFrame callback, then inside that callback call notifyDone? Also, I'd suggest adding some text to this page along the lines of "This test passes if it doesn't crash.". And then the expect result would have just that text and nothing else.
	24 }

	25 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/PageScaleConstraints.cpp » ('j') | no next file with comments »