More clean-up in server

More clean-up in server

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c369a8449ee377a057837494a3d21d3d8d43ff99

[Brian Wilkerson, 2016-09-20 14:58:05]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-09-20 14:58:06]

One step closer to using ContextBuilder.

[scheglov, 2016-09-20 15:29:14]

LGTM

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:141: packages.asMap().forEach((String
packagePath, Uri uri) {
Packages.map() says that it "Returns a map from package name to a base URI.".
So, maybe it should be (String name, Uri uri).

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/builder_test.dart (right):

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/builder_test.dart:107:
expect(builder.convertPackagesToMap(Packages.noPackages), isNotNull);
Should we check the returned map is empty here and below?

[Brian Wilkerson, 2016-09-20 15:39:16]

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:141: packages.asMap().forEach((String
packagePath, Uri uri) {
Done

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/builder_test.dart (right):

https://codereview.chromium.org/2350143004/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/builder_test.dart:107:
expect(builder.convertPackagesToMap(Packages.noPackages), isNotNull);
Done

[Brian Wilkerson, 2016-09-20 15:39:46]

Description was changed from

==========
More clean-up in server
==========

to

==========
More clean-up in server

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c369a8449ee377a057837494a3d21d3d8d43ff99
==========

[Brian Wilkerson, 2016-09-20 15:39:47]

Committed patchset #1 (id:1) manually as
c369a8449ee377a057837494a3d21d3d8d43ff99 (presubmit successful).