Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2350103003:
Added Home, end, PageUp, PageDown support in the ChromeVox menu (Closed)
|
Created:
4 years, 3 months ago by ultimatedbz Modified:
4 years, 3 months ago Reviewers:
dmazzoni CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded Home, end, PageUp, PageDown support in the ChromeVox menu
BUG=646238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/94f76462ac21655f7274c241930fb9e77b5b7a80
Cr-Commit-Position: refs/heads/master@{#419567}
Patch Set 1 #Patch Set 2 : Updated documentation of scrollToTop and scrollToBottom #
Messages
Total messages: 25 (16 generated)
Description was changed from ========== fixed some presubmit warnings Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG= ========== to ========== fixed some presubmit warnings Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by ultimatedbz@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== fixed some presubmit warnings Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== fixed some presubmit warnings Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
ultimatedbz@google.com changed reviewers: + dmazzoni@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The code change looks great! Please edit the change description: 1. The title should be "Added Home, end, PageUp, PageDown support in the ChromeVox menu" 2. The first line should be the same (get rid of the presubmit line) 3. Put the bug number on the BUG= line After that it should be ready to go and I'll approve
Description was changed from ========== fixed some presubmit warnings Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== fixed some presubmit warnings Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== fixed some presubmit warnings Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Hey Dominic, Just made the changes. Let me know if it's good!
The CQ bit was checked by dmazzoni@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ultimatedbz@google.com
The CQ bit was checked by ultimatedbz@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ultimatedbz@google.com
The CQ bit was checked by ultimatedbz@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Added Home, end, PageUp, PageDown support in the ChromeVox menu BUG=646238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/94f76462ac21655f7274c241930fb9e77b5b7a80 Cr-Commit-Position: refs/heads/master@{#419567} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/94f76462ac21655f7274c241930fb9e77b5b7a80 Cr-Commit-Position: refs/heads/master@{#419567} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
