Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2350093002: Update DEPS to always pull clang. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, Vadim Sh.
CC:
pdfium-reviews_googlegroups.com, Nico
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Update DEPS to always pull clang. If the --if-needed argument is passed to the clang update script then we depend on GYP_DEFINES to be set in order to update clang. We no longer define GYP_DEFINES so we fail to update clang (or checkout clang). BUG=chromium:647380 Committed: https://pdfium.googlesource.com/pdfium/+/b12fbddece4339c583524401f9b1465d968b3ae6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M DEPS View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dsinclair
PTAL. Do I also need to update the pdfium recipe to add GYP_DEFINE=clang=1 back?
4 years, 3 months ago (2016-09-19 14:32:11 UTC) #4
Dirk Pranke
lgtm. it looks like you only need clang=1 if you are using --if-needed.
4 years, 3 months ago (2016-09-19 17:17:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350093002/1
4 years, 3 months ago (2016-09-19 17:17:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/b12fbddece4339c583524401f9b1465d968b3ae6
4 years, 3 months ago (2016-09-19 17:45:19 UTC) #11
Lei Zhang
4 years, 3 months ago (2016-09-19 19:11:34 UTC) #12
Message was sent while issue was closed.
+thakis FYI

Powered by Google App Engine
This is Rietveld 408576698