Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2350073002: To prep for removing CMake bots, take them off the CQ and presubmit. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
rmistry, jcgregorio, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

To prep for removing CMake bots, take them off the CQ and presubmit. GN is now far more capable than our CMake builds. Time to officially end that experiment. Reminder how this lands: 1) this CL 2) remove the bots from the masters 3) remove the CMake recipe files 4) remove the CMake files I'm willing to wait on 4) until we can do GN -> CMake generation, but I don't want the bots to hold us back. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350073002 Committed: https://skia.googlesource.com/skia/+/9f262811b79f2c3f2c52c03cc2947431a36e8fbe

Patch Set 1 #

Total comments: 2

Patch Set 2 : pylint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M PRESUBMIT.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M infra/branch-config/cq.cfg View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
mtklein_C
4 years, 3 months ago (2016-09-19 14:13:58 UTC) #4
rmistry
lgtm https://codereview.chromium.org/2350073002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/2350073002/diff/1/PRESUBMIT.py#newcode43 PRESUBMIT.py:43: # pylint: disable=line-too-long Nit: Delete this line as ...
4 years, 3 months ago (2016-09-19 14:21:33 UTC) #6
mtklein
https://codereview.chromium.org/2350073002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/2350073002/diff/1/PRESUBMIT.py#newcode43 PRESUBMIT.py:43: # pylint: disable=line-too-long On 2016/09/19 14:21:32, rmistry wrote: > ...
4 years, 3 months ago (2016-09-19 14:34:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350073002/20001
4 years, 3 months ago (2016-09-19 15:35:03 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 16:08:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9f262811b79f2c3f2c52c03cc2947431a36e8fbe

Powered by Google App Engine
This is Rietveld 408576698