Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: content/browser/renderer_host/input/tap_suppression_controller.h

Issue 235003005: Consolidate all touch/gesture related constants in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compilation fixes Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/tap_suppression_controller.h
diff --git a/content/browser/renderer_host/input/tap_suppression_controller.h b/content/browser/renderer_host/input/tap_suppression_controller.h
index ef662f32f7b99bcc03be76b623a98264aef38d07..93977f950c3bd2ec4bb1ea83a55068e087164af5 100644
--- a/content/browser/renderer_host/input/tap_suppression_controller.h
+++ b/content/browser/renderer_host/input/tap_suppression_controller.h
@@ -19,7 +19,22 @@ class TapSuppressionControllerClient;
// GestureFlingCancel are suppressed.
class CONTENT_EXPORT TapSuppressionController {
public:
- explicit TapSuppressionController(TapSuppressionControllerClient* client);
+ struct CONTENT_EXPORT Config {
+ Config();
+
+ // Defaults to false, in which case no suppression is performed.
+ bool enabled;
+
+ // The maximum time allowed between a GestureFlingCancel and its
+ // corresponding tap down.
+ base::TimeDelta max_cancel_to_down_time;
+
+ // The maximum time allowed between a single tap's down and up events.
+ base::TimeDelta max_tap_gap_time;
+ };
+
+ TapSuppressionController(TapSuppressionControllerClient* client,
+ const Config& config);
virtual ~TapSuppressionController();
// Should be called whenever a GestureFlingCancel event is received.
@@ -49,17 +64,20 @@ class CONTENT_EXPORT TapSuppressionController {
friend class MockTapSuppressionController;
enum State {
+ DISABLED,
NOTHING,
GFC_IN_PROGRESS,
TAP_DOWN_STASHED,
LAST_CANCEL_STOPPED_FLING,
};
-
TapSuppressionControllerClient* client_;
base::OneShotTimer<TapSuppressionController> tap_down_timer_;
State state_;
+ base::TimeDelta max_cancel_to_down_time_;
+ base::TimeDelta max_tap_gap_time_;
+
// TODO(rjkroege): During debugging, the event times did not prove reliable.
// Replace the use of base::TimeTicks with an accurate event time when they
// become available post http://crbug.com/119556.

Powered by Google App Engine
This is Rietveld 408576698