Issue 235001: Backport r27035....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235001: Backport r27035.... (Closed)

Created:
11 years, 3 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
laforge

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Backport r27035 to 195 branch (chrome 3). Original review: http://codereview.chromium.org/223016 Fix a bug where if a PAC script ended with a comment and no newline, it would fail to parse. The library is now compiled and executed in a separate pass, rather than trying to append the source segments. BUG=http://crbug.com/22864 TEST=ProxyResolverV8Test.TrailingComment Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27057

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -14 lines)			Patch
A	net/data/proxy_resolver_v8_unittest/ends_with_comment.js	View	Binary file		0 comments	Download
M	net/proxy/proxy_resolver_v8.cc	View	3 chunks	+36 lines, -14 lines	0 comments	Download
M	net/proxy/proxy_resolver_v8_unittest.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages