Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 23500008: Telemetry: Replace actual groupcloned page with test page. (Closed)

Created:
7 years, 3 months ago by Dominik Grewe
Modified:
7 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Telemetry: Replace actual groupcloned page with test page. Disable actual http://groupcloned.com and add test page http://groupcloned.com/test/list-images-variable/index.html instead. The actual groupcloned page keeps failing in the key_mobile_sites page set. It seems to behave non-deterministically, i.e. it's trying to load different items on different invocations. This is despite Telemetry trying to get rid of all randomness. The problem with the non-determinism is that the page often tries to load resources that haven't been loaded during recording. BUG=238864 R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221468

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/perf/page_sets/key_mobile_sites.json View 2 chunks +14 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Dominik Grewe
There's a corresponding CL which adds the recording of the new page: https://chromereviews.googleplex.com/9917013 PTAL, thanks!
7 years, 3 months ago (2013-09-05 11:35:03 UTC) #1
tonyg
lgtm https://codereview.chromium.org/23500008/diff/1/tools/perf/page_sets/key_mobile_sites.json File tools/perf/page_sets/key_mobile_sites.json (right): https://codereview.chromium.org/23500008/diff/1/tools/perf/page_sets/key_mobile_sites.json#newcode215 tools/perf/page_sets/key_mobile_sites.json:215: "disabled": "Page behaves non-deterministically, replaced with test version ...
7 years, 3 months ago (2013-09-05 15:32:13 UTC) #2
Dominik Grewe
https://codereview.chromium.org/23500008/diff/1/tools/perf/page_sets/key_mobile_sites.json File tools/perf/page_sets/key_mobile_sites.json (right): https://codereview.chromium.org/23500008/diff/1/tools/perf/page_sets/key_mobile_sites.json#newcode215 tools/perf/page_sets/key_mobile_sites.json:215: "disabled": "Page behaves non-deterministically, replaced with test version for ...
7 years, 3 months ago (2013-09-05 15:38:11 UTC) #3
tonyg
On 2013/09/05 15:38:11, Dominik Grewe wrote: > https://codereview.chromium.org/23500008/diff/1/tools/perf/page_sets/key_mobile_sites.json > File tools/perf/page_sets/key_mobile_sites.json (right): > > https://codereview.chromium.org/23500008/diff/1/tools/perf/page_sets/key_mobile_sites.json#newcode215 ...
7 years, 3 months ago (2013-09-05 15:43:13 UTC) #4
Dominik Grewe
On 2013/09/05 15:43:13, tonyg wrote: > On 2013/09/05 15:38:11, Dominik Grewe wrote: > > > ...
7 years, 3 months ago (2013-09-05 15:46:12 UTC) #5
Sami
7 years, 3 months ago (2013-09-05 18:26:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r221468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698