Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: net/base/file_stream.h

Issue 23500006: URLFetcher won't call delegate until file is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mmenke's 3rd review Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/file_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/file_stream.h
diff --git a/net/base/file_stream.h b/net/base/file_stream.h
index 0fb3fb265697f317df69a0915979035bd2970461..9fe274759c7fac560acbdc0050b382ac0ac01db1 100644
--- a/net/base/file_stream.h
+++ b/net/base/file_stream.h
@@ -81,6 +81,16 @@ class NET_EXPORT FileStream {
// automatically closed when FileStream is destructed.
virtual int OpenSync(const base::FilePath& path, int open_flags);
+ // Returns ERR_IO_PENDING and closes the file asynchronously, calling
+ // |callback| when done.
+ // It is invalid to request any asynchronous operations while there is an
+ // in-flight asynchronous operation.
+ virtual int Close(const CompletionCallback& callback);
+
+ // Closes the file immediately and returns OK. If the file is open
+ // asynchronously, Close(const CompletionCallback&) should be used instead.
+ virtual int CloseSync();
+
// Returns true if Open succeeded and Close has not been called.
virtual bool IsOpen() const;
« no previous file with comments | « no previous file | net/base/file_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698