Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/file_stream_metrics.cc

Issue 23500006: URLFetcher won't call delegate until file is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/file_stream.h ('K') | « net/base/file_stream_metrics.h ('k') | net/url_request/url_fetcher_response_writer.h » ('j') | net/url_request/url_fetcher_response_writer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/file_stream_metrics.cc
diff --git a/net/base/file_stream_metrics.cc b/net/base/file_stream_metrics.cc
index 4dc0576325f3a312704d787ac85bfc80baa14986..3abd61fc02cbec9d49aecfe408d9eaf28af37252 100644
--- a/net/base/file_stream_metrics.cc
+++ b/net/base/file_stream_metrics.cc
@@ -19,7 +19,8 @@ const char* FileErrorSourceStrings[] = {
"SEEK",
"FLUSH",
"SET_EOF",
- "GET_SIZE"
+ "GET_SIZE",
+ "CLOSE"
};
COMPILE_ASSERT(ARRAYSIZE_UNSAFE(FileErrorSourceStrings) ==
@@ -88,6 +89,12 @@ void RecordFileError(int error, FileErrorSource source, bool record) {
max_bucket);
break;
+ case FILE_ERROR_SOURCE_CLOSE:
+ UMA_HISTOGRAM_ENUMERATION("Net.FileError_Close", error, max_error);
+ UMA_HISTOGRAM_ENUMERATION("Net.FileErrorRange_Close", bucket,
+ max_bucket);
+ break;
+
default:
break;
}
« net/base/file_stream.h ('K') | « net/base/file_stream_metrics.h ('k') | net/url_request/url_fetcher_response_writer.h » ('j') | net/url_request/url_fetcher_response_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698