URLFetcher won't call delegate until file is closed.

net/url_request/url_fetcher_response_writer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_fetcher_response_writer.h"
 
 #include "base/file_util.h"
 #include "base/location.h"
 #include "base/task_runner.h"
 #include "base/task_runner_util.h"
@@ skipping 84 matching lines @@
                                               weak_factory_.GetWeakPtr(),
                                               callback));
   if (result < 0 && result != ERR_IO_PENDING) {
     error_code_ = result;
     CloseAndDeleteFile();
   }
   return result;
 }
 
 int URLFetcherFileWriter::Finish(const CompletionCallback& callback) {
+  int result = file_stream_->Close(base::Bind(
+      &URLFetcherFileWriter::CloseComplete, base::Unretained(this), callback));
+  if (result != ERR_IO_PENDING) {

[Sorin Jianu, 2013/09/05 19:59:12]

Remove the full bracing for the if statement, per Chrome style guide.

[waffles, 2013/09/05 20:31:52]

Done.

+    file_stream_.reset();
+  }
+  return result;
+}
+
+void URLFetcherFileWriter::CloseComplete(const CompletionCallback& callback,
+                                         int result) {
+  // Either we closed the file or we can't; either way destroy the file_stream.
   file_stream_.reset();
-  return OK;
+  callback.Run(result);
 }
 
 void URLFetcherFileWriter::DidWrite(const CompletionCallback& callback,
                                     int result) {
   if (result < 0) {
     error_code_ = result;
     CloseAndDeleteFile();
   }
   callback.Run(result);
 }
@@ skipping 45 matching lines @@
     total_bytes_written_ = 0;
     owns_file_ = true;
   } else {
     error_code_ = result;
     CloseAndDeleteFile();
   }
   callback.Run(result);
 }
 
 }  // namespace net