Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2349983002: [turbofan] Support virtual register redirection in instruction selector. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Support virtual register redirection in instruction selector. Committed: https://crrev.com/f4c88a5e5bfa746ad287cf155958a83999f061a2 Cr-Commit-Position: refs/heads/master@{#39492}

Patch Set 1 #

Patch Set 2 : Fix Win64? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -16 lines) Patch
M src/compiler/instruction.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 5 chunks +56 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jarin
Could you take a look, please? Unfortunately, it does not improve navier-stokes score, but it ...
4 years, 3 months ago (2016-09-18 22:03:30 UTC) #8
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-19 03:40:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349983002/20001
4 years, 3 months ago (2016-09-19 07:59:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 08:02:29 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 08:02:58 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4c88a5e5bfa746ad287cf155958a83999f061a2
Cr-Commit-Position: refs/heads/master@{#39492}

Powered by Google App Engine
This is Rietveld 408576698