Repeat window snapshot copy request on failure

Repeat window snapshot copy request on failure

We're hitting a bug where copy requests sporadically fail. The complete
fix is pretty involved (see https://crbug.com/644992 ), but just
repeating the copy request a few times should greatly reduce the
frequency of the problem and should be mergeable to M54.

BUG=644569
Committed: https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86
Cr-Commit-Position: refs/heads/master@{#422012}

[jbauman, 2016-09-20 02:46:11]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 02:46:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 03:43:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 03:43:25]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-09-29 00:11:29]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 00:11:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 00:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:23:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbauman, 2016-09-29 00:28:36]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 00:28:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 01:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 01:16:34]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-09-29 01:21:28]

Description was changed from

==========
Repeat copy request

BUG=
==========

to

==========
Repeat window snapshot copy request on failure

We're hitting a bug where copy requests sporadically fail. The complete
fix is pretty involved (see https://crbug.com/644992 ), but just
repeating the copy request a few times should greatly reduce the
frequency of the problem and should be mergeable to M54.

BUG=644569
==========

[jbauman, 2016-09-29 01:22:42]

jbauman@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-09-29 04:45:10]

https://codereview.chromium.org/2349973009/diff/40001/ui/snapshot/snapshot_au...
File ui/snapshot/snapshot_aura.cc (right):

https://codereview.chromium.org/2349973009/diff/40001/ui/snapshot/snapshot_au...
ui/snapshot/snapshot_aura.cc:27: WindowCapturer(aura::Window* window) :
window_(window) {
explicit

https://codereview.chromium.org/2349973009/diff/40001/ui/snapshot/snapshot_au...
ui/snapshot/snapshot_aura.cc:39: aura::Window* window_;
DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/2349973009/diff/40001/ui/snapshot/snapshot_au...
ui/snapshot/snapshot_aura.cc:78: MakeAsyncCopyRequest(
Do we want to delay this request? Does the failure happen quickly enough that we
may be issuing too many retries too quickly? Would that be problematic, e.g.
cause the system ui to freeze?

https://codereview.chromium.org/2349973009/diff/40001/ui/snapshot/snapshot_au...
ui/snapshot/snapshot_aura.cc:93: base::MakeUnique<WindowCapturer>(window);
You can use aura::WindowTracker if you want instead.

[jbauman, 2016-09-29 20:52:35]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:52:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 21:38:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 21:38:43]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-09-29 21:43:55]

On 2016/09/29 04:45:10, sadrul wrote:
>
https://codereview.chromium.org/2349973009/diff/40001/ui/snapshot/snapshot_au...
> ui/snapshot/snapshot_aura.cc:78: MakeAsyncCopyRequest(
> Do we want to delay this request? Does the failure happen quickly enough that
we
> may be issuing too many retries too quickly? Would that be problematic, e.g.
> cause the system ui to freeze?

No, when this fails very little work has been done (mostly just an unnecessary
browser commit), so I don't think any extra ratelimiting is necessary.
> 
>
https://codereview.chromium.org/2349973009/diff/40001/ui/snapshot/snapshot_au...
> ui/snapshot/snapshot_aura.cc:93: base::MakeUnique<WindowCapturer>(window);
> You can use aura::WindowTracker if you want instead.

Thanks, that works well.

[sadrul, 2016-09-30 01:37:22]

lgtm

[jbauman, 2016-09-30 01:49:49]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2016-09-30 01:50:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 01:57:12]

Description was changed from

==========
Repeat window snapshot copy request on failure

We're hitting a bug where copy requests sporadically fail. The complete
fix is pretty involved (see https://crbug.com/644992 ), but just
repeating the copy request a few times should greatly reduce the
frequency of the problem and should be mergeable to M54.

BUG=644569
==========

to

==========
Repeat window snapshot copy request on failure

We're hitting a bug where copy requests sporadically fail. The complete
fix is pretty involved (see https://crbug.com/644992 ), but just
repeating the copy request a few times should greatly reduce the
frequency of the problem and should be mergeable to M54.

BUG=644569
==========

[commit-bot: I haz the power, 2016-09-30 01:57:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-30 02:00:52]

Description was changed from

==========
Repeat window snapshot copy request on failure

We're hitting a bug where copy requests sporadically fail. The complete
fix is pretty involved (see https://crbug.com/644992 ), but just
repeating the copy request a few times should greatly reduce the
frequency of the problem and should be mergeable to M54.

BUG=644569
==========

to

==========
Repeat window snapshot copy request on failure

We're hitting a bug where copy requests sporadically fail. The complete
fix is pretty involved (see https://crbug.com/644992 ), but just
repeating the copy request a few times should greatly reduce the
frequency of the problem and should be mergeable to M54.

BUG=644569

Committed: https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86
Cr-Commit-Position: refs/heads/master@{#422012}
==========

[commit-bot: I haz the power, 2016-09-30 02:00:53]

Patchset 4 (id:??) landed as
https://crrev.com/cebea890c1e2a49072e0e5ec2bd8823ae2bb2a86
Cr-Commit-Position: refs/heads/master@{#422012}