Run IME tests with and without ImeThread feature

Run IME tests with and without ImeThread feature

We are about to launch ImeThread (targeting M54), and in case we fail to
launch, we should be able to disable the feature safely.

BUG=648482
Committed: https://crrev.com/d6a84dbb67c7d6a8eb47d76a34d0e2627670f026
Cr-Commit-Position: refs/heads/master@{#419980}

[Changwan Ryu, 2016-09-20 02:28:58]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 02:29:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:31:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 02:31:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Changwan Ryu, 2016-09-20 02:32:24]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 02:32:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Changwan Ryu, 2016-09-20 02:36:30]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 02:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 03:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 03:13:26]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Changwan Ryu, 2016-09-20 05:06:26]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 05:06:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Changwan Ryu, 2016-09-20 05:10:27]

changwan@chromium.org changed reviewers:
+ aelias@chromium.org, jbudorick@chromium.org

[Changwan Ryu, 2016-09-20 05:10:28]

PTAL

[commit-bot: I haz the power, 2016-09-20 05:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 05:20:20]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2016-09-20 13:49:20]

non-owner lgtm w/ question

https://codereview.chromium.org/2349973008/diff/60001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/2349973008/diff/60001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:151:
if (usingReplicaInputConnection()) return;
What's the reasoning behind adding these? Is this something that always and only
happens when running w/ ImeThread enabled?

If so, you could also use @ParameterizedTest.Sets on individual tests to replace
the class-level one. (If not, this is fine.)

[Changwan Ryu, 2016-09-20 23:55:58]

https://codereview.chromium.org/2349973008/diff/60001/content/public/android/...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/2349973008/diff/60001/content/public/android/...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:151:
if (usingReplicaInputConnection()) return;
On 2016/09/20 13:49:19, jbudorick wrote:
> What's the reasoning behind adding these? Is this something that always and
only
> happens when running w/ ImeThread enabled?
Yes, that's the reason I have these lines.

> 
> If so, you could also use @ParameterizedTest.Sets on individual tests to
replace
> the class-level one. (If not, this is fine.)

Hmm.. While @ParameterizedTest.Set can help avoid running this test in one case,
I prefer this succinct form. In the near future this should just go away
anyways. Thanks for the tip, though!

[aelias_OOO_until_Jul13, 2016-09-21 03:14:47]

lgtm

[Changwan Ryu, 2016-09-21 05:24:21]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-09-21 05:24:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 05:41:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-21 05:43:19]

Description was changed from

==========
Run IME tests with and without ImeThread feature

We are about to launch ImeThread (targeting M54), and in case we fail to
launch, we should be able to disable the feature safely.

BUG=648482
==========

to

==========
Run IME tests with and without ImeThread feature

We are about to launch ImeThread (targeting M54), and in case we fail to
launch, we should be able to disable the feature safely.

BUG=648482

Committed: https://crrev.com/d6a84dbb67c7d6a8eb47d76a34d0e2627670f026
Cr-Commit-Position: refs/heads/master@{#419980}
==========

[commit-bot: I haz the power, 2016-09-21 05:43:20]

Patchset 4 (id:??) landed as
https://crrev.com/d6a84dbb67c7d6a8eb47d76a34d0e2627670f026
Cr-Commit-Position: refs/heads/master@{#419980}