Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2349973006: Implement exception and finished reason in RequestFinishedInfo (Closed)
Patch Set: rebase again? Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
index 3030932fb3f29636a501ab9fc48523ccd90c40d4..3b106ddbabc81ec8782e95c04f2413d1bbd59010 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
@@ -99,6 +99,8 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertNotNull(requestInfo.getResponseInfo());
assertEquals(newHashSet("request annotation", this), // Use sets for unordered comparison.
new HashSet<Object>(requestInfo.getAnnotations()));
+ assertEquals(RequestFinishedInfo.SUCCEEDED, requestInfo.getFinishedReason());
+ assertNull(requestInfo.getException());
RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metrics);
// Check old (deprecated) timing metrics
@@ -144,6 +146,8 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertNotNull(requestInfo.getResponseInfo());
assertEquals(newHashSet("request annotation", this), // Use sets for unordered comparison.
new HashSet<Object>(requestInfo.getAnnotations()));
+ assertEquals(RequestFinishedInfo.SUCCEEDED, requestInfo.getFinishedReason());
+ assertNull(requestInfo.getException());
RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metrics);
assertTrue(metrics.getTotalTimeMs() > 0);
@@ -189,6 +193,10 @@ public class RequestFinishedInfoTest extends CronetTestBase {
new HashSet<Object>(firstRequestInfo.getAnnotations()));
assertEquals(newHashSet("request annotation", this),
new HashSet<Object>(secondRequestInfo.getAnnotations()));
+ assertEquals(RequestFinishedInfo.SUCCEEDED, firstRequestInfo.getFinishedReason());
+ assertEquals(RequestFinishedInfo.SUCCEEDED, secondRequestInfo.getFinishedReason());
+ assertNull(firstRequestInfo.getException());
+ assertNull(secondRequestInfo.getException());
RequestFinishedInfo.Metrics firstMetrics = firstRequestInfo.getMetrics();
assertNotNull("RequestFinishedInfo.getMetrics() must not be null", firstMetrics);
assertTrue(firstMetrics.getTotalTimeMs() > 0);
@@ -229,6 +237,10 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertNotNull("RequestFinishedInfo.Listener must be called", requestInfo);
assertEquals(connectionRefusedUrl, requestInfo.getUrl());
assertTrue(requestInfo.getAnnotations().isEmpty());
+ assertEquals(RequestFinishedInfo.FAILED, requestInfo.getFinishedReason());
+ assertNotNull(requestInfo.getException());
+ assertEquals(UrlRequestException.ERROR_CONNECTION_REFUSED,
+ requestInfo.getException().getErrorCode());
RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metrics);
// The failure is occasionally fast enough that time reported is 0, so just check for null
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698