Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2349973005: DevTools: move repeatCountElement from contentElement into wrapperElement (Closed)

Created:
4 years, 3 months ago by luoe
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move repeatCountElement from contentElement into wrapperElement Currently, a ConsoleViewMessage's element() returns a wrapper whose only children are nesting level marker div's and a contentElement() with the actual message. This CL extracts the repeatCountElement, shown for repeated messages, out of the contentElement(). By doing so, we isolate the actual message content. BUG= Committed: https://crrev.com/5147740c817460279d7cd6af8f24220ab88e389e Cr-Commit-Position: refs/heads/master@{#419914}

Patch Set 1 #

Messages

Total messages: 19 (14 generated)
luoe
While there is no bug directly associated with this issue, this should allow us to ...
4 years, 3 months ago (2016-09-19 21:37:24 UTC) #4
lushnikov
lgtm
4 years, 3 months ago (2016-09-20 18:08:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349973005/1
4 years, 3 months ago (2016-09-21 00:06:26 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 00:16:32 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 00:20:30 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5147740c817460279d7cd6af8f24220ab88e389e
Cr-Commit-Position: refs/heads/master@{#419914}

Powered by Google App Engine
This is Rietveld 408576698