Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 234993003: MIPS: Implement handlified String::Equals and Name::Equals. (Closed)

Created:
6 years, 8 months ago by palfia
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Implement handlified String::Equals and Name::Equals. Port r20669 (29a6ec29) Note: This commit fixes a typo. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
PTAL.
6 years, 8 months ago (2014-04-11 12:36:54 UTC) #1
danno
lgtm
6 years, 8 months ago (2014-04-11 12:38:13 UTC) #2
palfia
Committed patchset #1 manually as r20688 (presubmit successful).
6 years, 8 months ago (2014-04-11 12:40:32 UTC) #3
Yang
On 2014/04/11 12:38:13, danno wrote: > lgtm Argh. Sorry about that!
6 years, 8 months ago (2014-04-11 12:40:39 UTC) #4
palfia
6 years, 8 months ago (2014-04-11 12:43:30 UTC) #5
Message was sent while issue was closed.
On 2014/04/11 12:40:39, Yang wrote:
> On 2014/04/11 12:38:13, danno wrote:
> > lgtm
> 
> Argh. Sorry about that!

No problem! :-)

Powered by Google App Engine
This is Rietveld 408576698