Issue 23499013: Fix uninitialized string bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23499013: Fix uninitialized string bug (Closed)

Created:
7 years, 3 months ago by robertphillips

Modified:
7 years, 3 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

In the case I'm seeing GrGLEffectMatrix::emitCode is being called with a non-null suffix but the identity matrix path is being taken. This causes the test app to crash in Windows Release on the GLPrograms step.

Patch Set 1 #

Patch Set 2 : Take 2 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	src/gpu/gl/GrGLEffectMatrix.cpp	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

PTAL. In this version it is clearer that the uniform name isn't used in the ...

7 years, 3 months ago (2013-09-10 17:21:21 UTC) #2

Message was sent while issue was closed.

committed as r11182

Expand Messages | Collapse Messages