Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: chrome/utility/media_galleries/pmp_column_reader_unittest.cc

Issue 23499006: Media Galleries API Picasa: Add file watch to invalidate database data on disk write. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/media_galleries/picasa_album_table_reader_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/media_galleries/pmp_column_reader_unittest.cc
diff --git a/chrome/utility/media_galleries/pmp_column_reader_unittest.cc b/chrome/utility/media_galleries/pmp_column_reader_unittest.cc
index a1f44b76705eb7e540977349e34abcdd94330e63..2fda7401acc9f3b4495ebb4b8f9164118dcda7b4 100644
--- a/chrome/utility/media_galleries/pmp_column_reader_unittest.cc
+++ b/chrome/utility/media_galleries/pmp_column_reader_unittest.cc
@@ -72,9 +72,6 @@ bool DoRead(const PmpColumnReader* reader, uint32 row, uint64* target) {
template<class T>
void TestValid(const PmpFieldType field_type,
const std::vector<T>& elems) {
- PmpTestHelper test_helper("test");
- ASSERT_TRUE(test_helper.Init());
-
PmpColumnReader reader;
std::vector<char> data =
PmpTestHelper::MakeHeaderAndBody(field_type, elems.size(), elems);
@@ -91,9 +88,6 @@ void TestValid(const PmpFieldType field_type,
template<class T>
void TestMalformed(const PmpFieldType field_type,
const std::vector<T>& elems) {
- PmpTestHelper test_helper("test");
- ASSERT_TRUE(test_helper.Init());
-
PmpColumnReader reader_too_few_declared_rows;
std::vector<char> data_too_few_declared_rows =
PmpTestHelper::MakeHeaderAndBody(field_type, elems.size()-1, elems);
@@ -140,9 +134,6 @@ void TestPrimitive(const PmpFieldType field_type) {
TEST(PmpColumnReaderTest, HeaderParsingAndValidation) {
- PmpTestHelper test_helper("test");
- ASSERT_TRUE(test_helper.Init());
-
PmpColumnReader reader_good_header;
std::vector<char> good_header =
PmpTestHelper::MakeHeader(PMP_TYPE_STRING, 0);
« no previous file with comments | « chrome/utility/media_galleries/picasa_album_table_reader_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698