Improve <webview> autosize:

Improve <webview> autosize:
a. Expand/shrink <webview> element when 'sizechange' event fires, to
match with the new view size (in shim).
b. For SW mode, fix a bug where damage buffer would remain smaller than
the view size and would result in crash. Added test for this case.

BUG=
Test=WebViewTest.AutoSize.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220402

[Fady Samuel, 2013-08-27 14:16:17]

https://codereview.chromium.org/23499003/diff/1/chrome/renderer/resources/ext...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/23499003/diff/1/chrome/renderer/resources/ext...
chrome/renderer/resources/extensions/web_view.js:118:
webview.webviewNode_.style.width = webviewEvent.newWidth + 'px';
Check the current bounds here to make sure we're not outside the currently
specified constraints. If we are then don't resize the <webview>.

https://codereview.chromium.org/23499003/diff/1/chrome/test/data/extensions/p...
File chrome/test/data/extensions/platform_apps/web_view/autosize/main.js
(right):

https://codereview.chromium.org/23499003/diff/1/chrome/test/data/extensions/p...
chrome/test/data/extensions/platform_apps/web_view/autosize/main.js:27: // then
we won't have enough memory in damage buffer to render.
That doesn't make sense to me. We set the damage buffer to be 800*800 or
whatever the maximum constraints are.

https://codereview.chromium.org/23499003/diff/1/content/renderer/browser_plug...
File content/renderer/browser_plugin/browser_plugin.cc (right):

https://codereview.chromium.org/23499003/diff/1/content/renderer/browser_plug...
content/renderer/browser_plugin/browser_plugin.cc:518: needs_new_damage_buffer =
true;
I don't understand this fix. We set the damage buffer equal to the maximum
constraints, right? When would this happen?

[Fady Samuel, 2013-08-27 14:18:52]

Probably also useful to record the UMA action in BrowserPluginGuest::OnSetSize
when EnableAutoResize is called to see how much usage autosize is getting.

[lazyboy, 2013-08-27 23:22:17]

https://chromiumcodereview.appspot.com/23499003/diff/1/chrome/renderer/resour...
File chrome/renderer/resources/extensions/web_view.js (right):

https://chromiumcodereview.appspot.com/23499003/diff/1/chrome/renderer/resour...
chrome/renderer/resources/extensions/web_view.js:118:
webview.webviewNode_.style.width = webviewEvent.newWidth + 'px';
On 2013/08/27 14:16:18, Fady Samuel wrote:
> Check the current bounds here to make sure we're not outside the currently
> specified constraints. If we are then don't resize the <webview>.

Done.

https://chromiumcodereview.appspot.com/23499003/diff/1/chrome/test/data/exten...
File chrome/test/data/extensions/platform_apps/web_view/autosize/main.js
(right):

https://chromiumcodereview.appspot.com/23499003/diff/1/chrome/test/data/exten...
chrome/test/data/extensions/platform_apps/web_view/autosize/main.js:27: // then
we won't have enough memory in damage buffer to render.
On 2013/08/27 14:16:18, Fady Samuel wrote:
> That doesn't make sense to me. We set the damage buffer to be 800*800 or
> whatever the maximum constraints are.

See other comment.

https://chromiumcodereview.appspot.com/23499003/diff/1/content/renderer/brows...
File content/renderer/browser_plugin/browser_plugin.cc (right):

https://chromiumcodereview.appspot.com/23499003/diff/1/content/renderer/brows...
content/renderer/browser_plugin/browser_plugin.cc:518: needs_new_damage_buffer =
true;
On 2013/08/27 14:16:18, Fady Samuel wrote:
> I don't understand this fix. We set the damage buffer equal to the maximum
> constraints, right? When would this happen?

As discussed offline, the CL changed quite a bit and we are detecting this case
via dirty flag now.

[Fady Samuel, 2013-08-28 19:14:38]

This is really awesome! This will make a bunch of developers happy! :-)

Just one ask: could you please diff against my cleanup CL, and move some of the
code in customHandler to helper method?

https://codereview.chromium.org/23499003/diff/12001/chrome/renderer/resources...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/23499003/diff/12001/chrome/renderer/resources...
chrome/renderer/resources/extensions/web_view.js:131: var node =
webview.webviewNode_;
Could you please move all this code to a helper method in WebViewInternal? It
would be nice to keep WEB_VIEW_EXT_EVENTS as succinct as possible to allow us
and any future <webview> developers to understand what events are supported by
<webview> at a glance.

[lazyboy, 2013-08-28 20:41:17]

Extracted sizechanged event handler to a separate function.
Renamed variable according to the Clean up CL.

[Fady Samuel, 2013-08-28 20:45:27]

lgtm after one comment is addressed. Thanks! :-)

https://chromiumcodereview.appspot.com/23499003/diff/15001/chrome/test/data/e...
File chrome/test/data/extensions/platform_apps/web_view/autosize/main.js
(right):

https://chromiumcodereview.appspot.com/23499003/diff/15001/chrome/test/data/e...
chrome/test/data/extensions/platform_apps/web_view/autosize/main.js:50:
document.body.appendChild(webview);
Why isn't it already in the DOM?

[lazyboy, 2013-08-28 22:09:37]

https://chromiumcodereview.appspot.com/23499003/diff/15001/chrome/test/data/e...
File chrome/test/data/extensions/platform_apps/web_view/autosize/main.js
(right):

https://chromiumcodereview.appspot.com/23499003/diff/15001/chrome/test/data/e...
chrome/test/data/extensions/platform_apps/web_view/autosize/main.js:50:
document.body.appendChild(webview);
On 2013/08/28 20:45:27, Fady Samuel wrote:
> Why isn't it already in the DOM?

Done.

[commit-bot: I haz the power, 2013-08-28 23:07:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/23499003/28001

[commit-bot: I haz the power, 2013-08-29 02:18:53]

Retried try job too often on win_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-08-29 02:32:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/23499003/28001

[commit-bot: I haz the power, 2013-08-29 05:54:11]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-08-29 16:40:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/23499003/27001

[commit-bot: I haz the power, 2013-08-29 22:37:59]

Change committed as 220402