Change LoadFailObserver to use WebContentsObserver::DidFinishNavigation notification.

Change LoadFailObserver to use WebContentsObserver::DidFinishNavigation notification.

This fixes the following browser test for PlzNavigate:
  InProcessBrowserTest.ExternalConnectionFail

BUG=638596
Committed: https://crrev.com/cd3181872bd0e0ee72e080e0c120049fd936718c
Cr-Commit-Position: refs/heads/master@{#419477}

[yzshen1, 2016-09-16 23:05:07]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[yzshen1, 2016-09-16 23:05:20]

yzshen@chromium.org changed reviewers:
+ jam@chromium.org

[yzshen1, 2016-09-16 23:05:20]

Hi, John.

Would you please take a look? Thanks!

[commit-bot: I haz the power, 2016-09-16 23:05:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:09:48]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2016-09-16 23:20:56]

On 2016/09/16 23:05:20, yzshen1 wrote:
> Hi, John.
> 
> Would you please take a look? Thanks!

Those bots are failing the "analyze" step. That doesn't seem like the fault of
this CL.

[jam, 2016-09-19 15:34:00]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 15:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-19 15:36:04]

lgtm

[commit-bot: I haz the power, 2016-09-19 16:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 16:04:13]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2016-09-19 16:15:35]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-09-19 16:15:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 16:20:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-19 16:23:36]

Description was changed from

==========
Change LoadFailObserver to use WebContentsObserver::DidFinishNavigation
notification.

This fixes the following browser test for PlzNavigate:
  InProcessBrowserTest.ExternalConnectionFail

BUG=638596
==========

to

==========
Change LoadFailObserver to use WebContentsObserver::DidFinishNavigation
notification.

This fixes the following browser test for PlzNavigate:
  InProcessBrowserTest.ExternalConnectionFail

BUG=638596

Committed: https://crrev.com/cd3181872bd0e0ee72e080e0c120049fd936718c
Cr-Commit-Position: refs/heads/master@{#419477}
==========

[commit-bot: I haz the power, 2016-09-19 16:23:37]

Patchset 1 (id:??) landed as
https://crrev.com/cd3181872bd0e0ee72e080e0c120049fd936718c
Cr-Commit-Position: refs/heads/master@{#419477}