Issue 2349853002: VM: Fix for deadlock with background tasks.

Issue 2349853002: VM: Fix for deadlock with background tasks. (Closed)

Created:
4 years, 3 months ago by Florian Schneider

Modified:
4 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix for deadlock with background tasks. We have to do NotifyAll whenever a task finishes. Also, remove thread notifications when a task is created, since we only ever wait for tasks to finish. BUG=#27365 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9f00ce2b6edec116e5e1ff94f9fb6324102d637f

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	runtime/vm/dart_api_state.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	runtime/vm/gc_sweeper.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Florian Schneider

4 years, 3 months ago (2016-09-16 22:03:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9f00ce2b6edec116e5e1ff94f9fb6324102d637f (presubmit successful).