|
|
Chromium Code Reviews
DescriptionAdd a note on android_optional_gpu_tests_rel trybot to manual rolls doc.
BUG=chromium:646924
NOTRY=true
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/ac4a5f45193ad872b1563990d2508d847920336d
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 21 (8 generated)
ynovikov@chromium.org changed reviewers: + kbr@chromium.org, nednguyen@google.com
kbr@chromium.org changed reviewers: + eyaich@chromium.org
+eyaich LGTM from my standpoint.
On 2016/09/16 22:44:57, Ken Russell wrote: > +eyaich > > LGTM from my standpoint. lgtm
On 2016/09/19 14:20:40, eyaich1 wrote: > On 2016/09/16 22:44:57, Ken Russell wrote: > > +eyaich > > > > LGTM from my standpoint. > > lgtm I think I need OWNERS review on this. Ned?
lgtm
The CQ bit was checked by ynovikov@chromium.org
On 2016/09/19 19:02:09, nednguyen wrote: > lgtm Thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...) Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)
On 2016/09/19 19:42:25, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...) > Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...) Ned, Emily: looks like the Catapult tryservers are busted. Can you investigate?
On 2016/09/19 20:17:45, Ken Russell wrote: > On 2016/09/19 19:42:25, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, > > > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...) > > Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, > > > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...) > > Ned, Emily: looks like the Catapult tryservers are busted. Can you investigate? Maybe it is related to skia roll I requested in https://skia-review.googlesource.com/2420?
On 2016/09/19 20:21:07, ynovikov wrote: > On 2016/09/19 20:17:45, Ken Russell wrote: > > On 2016/09/19 19:42:25, commit-bot: I haz the power wrote: > > > Try jobs failed on following builders: > > > Catapult Android Tryserver on master.tryserver.client.catapult > (JOB_FAILED, > > > > > > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...) > > > Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, > > > > > > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...) > > > > Ned, Emily: looks like the Catapult tryservers are busted. Can you > investigate? > > Maybe it is related to skia roll I requested in > https://skia-review.googlesource.com/2420 The catapult tryserver problem is tracked in https://github.com/catapult-project/catapult/issues/2816 For your change, feel free to add NOTRY=true
Description was changed from ========== Add a note on android_optional_gpu_tests_rel trybot to manual rolls doc. BUG=chromium:646924 ========== to ========== Add a note on android_optional_gpu_tests_rel trybot to manual rolls doc. BUG=chromium:646924 NOTRY=true ==========
The CQ bit was checked by ynovikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, eyaich@chromium.org, kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2349843003/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a note on android_optional_gpu_tests_rel trybot to manual rolls doc. BUG=chromium:646924 NOTRY=true ========== to ========== Add a note on android_optional_gpu_tests_rel trybot to manual rolls doc. BUG=chromium:646924 NOTRY=true Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
