Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2349833003:
Milo: master grpc endpoint fix (Closed)
|
Created:
4 years, 3 months ago by Ryan Tseng Modified:
4 years, 3 months ago CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel Target Ref:
refs/heads/master Project:
luci-go Visibility:
Public. |
DescriptionMilo: master grpc endpoint fix
the writer needs to be closed (flushed) otherwise it can't be read out.
BUG=642461
Committed: https://github.com/luci/luci-go/commit/3518c0e283b1f61e65913b651c9d87ec43c0fd93
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hinoka@google.com changed reviewers: + dnj@chromium.org
ptal, 2 line change.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hinoka@google.com changed reviewers: + estaab@chromium.org
+estaab, since dnj is troopin
lgtm
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/315d076fa0145110) Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/315d076ea5f6bd10) Luci-go Mac Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/315d076f68dfff10) Luci-go Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/315d076e72c61510)
The CQ bit was checked by dnj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Milo: master grpc endpoint fix the writer needs to be closed (flushed) otherwise it can't be read out. BUG=642461 ========== to ========== Milo: master grpc endpoint fix the writer needs to be closed (flushed) otherwise it can't be read out. BUG=642461 Committed: https://github.com/luci/luci-go/commit/3518c0e283b1f61e65913b651c9d87ec43c0fd93 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://github.com/luci/luci-go/commit/3518c0e283b1f61e65913b651c9d87ec43c0fd93 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
