Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: ios/net/cookies/cookie_store_ios.mm

Issue 2349823003: Pass a RemovalCause to CookieChangedCallback (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/net/cookies/cookie_store_ios.h ('k') | ios/net/cookies/cookie_store_ios_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/cookies/cookie_store_ios.mm
diff --git a/ios/net/cookies/cookie_store_ios.mm b/ios/net/cookies/cookie_store_ios.mm
index aa02bf8b43c6c8839f7fa74578fb3bccfeef3441..2767aa2029ef060e1928bd18e195596f236eaf8a 100644
--- a/ios/net/cookies/cookie_store_ios.mm
+++ b/ios/net/cookies/cookie_store_ios.mm
@@ -967,8 +967,10 @@ void CookieStoreIOS::OnSystemCookiesChanged() {
std::vector<net::CanonicalCookie> added_cookies;
if (UpdateCacheForCookieFromSystem(key.first, key.second, &removed_cookies,
&added_cookies)) {
- RunCallbacksForCookies(key.first, key.second, removed_cookies, true);
- RunCallbacksForCookies(key.first, key.second, added_cookies, false);
+ RunCallbacksForCookies(key.first, key.second, removed_cookies,
+ net::CookieStore::ChangeCause::UNKNOWN_DELETION);
+ RunCallbacksForCookies(key.first, key.second, added_cookies,
+ net::CookieStore::ChangeCause::INSERTED);
}
}
@@ -1020,7 +1022,7 @@ void CookieStoreIOS::RunCallbacksForCookies(
const GURL& url,
const std::string& name,
const std::vector<net::CanonicalCookie>& cookies,
- bool removed) {
+ net::CookieStore::ChangeCause cause) {
DCHECK(thread_checker_.CalledOnValidThread());
if (cookies.empty())
return;
@@ -1029,7 +1031,7 @@ void CookieStoreIOS::RunCallbacksForCookies(
CookieChangedCallbackList* callbacks = hook_map_[key].get();
for (const auto& cookie : cookies) {
DCHECK_EQ(name, cookie.Name());
- callbacks->Notify(cookie, removed);
+ callbacks->Notify(cookie, cause);
}
}
@@ -1062,8 +1064,10 @@ void CookieStoreIOS::GotCookieListFor(const std::pair<GURL, std::string> key,
std::vector<net::CanonicalCookie> added_cookies;
if (cookie_cache_->Update(key.first, key.second, filtered, &removed_cookies,
&added_cookies)) {
- RunCallbacksForCookies(key.first, key.second, removed_cookies, true);
- RunCallbacksForCookies(key.first, key.second, added_cookies, false);
+ RunCallbacksForCookies(key.first, key.second, removed_cookies,
+ net::CookieStore::ChangeCause::UNKNOWN_DELETION);
+ RunCallbacksForCookies(key.first, key.second, added_cookies,
+ net::CookieStore::ChangeCause::INSERTED);
}
}
« no previous file with comments | « ios/net/cookies/cookie_store_ios.h ('k') | ios/net/cookies/cookie_store_ios_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698