Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 23498035: cc: Always use SetNeedsBeginFrame to request the next BeginFrame (Closed)

Created:
7 years, 3 months ago by brianderson
Modified:
7 years, 3 months ago
Reviewers:
epenner, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@epenner23495022
Visibility:
Public.

Description

cc: Always use SetNeedsBeginFrame to request the next BeginFrame This avoids relying on SwapBuffers to implicitly trigger the next BeginFrame. Only a single code path is used to request the next BeginFrame now: SetNeedsBeginFrame(true). This avoids issues where OutputSurface subclasses might not call OutputSurface::DidSwap() when they need to or when we early out a swap request and don't actually swap anything. BUG=289755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223218

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -46 lines) Patch
M cc/output/output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface.cc View 7 chunks +8 lines, -9 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 3 chunks +6 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 5 chunks +10 lines, -28 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 9 chunks +60 lines, -6 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
brianderson
This was a pretty straight forward rebase. I've added a comment to the only part ...
7 years, 3 months ago (2013-09-13 20:19:10 UTC) #1
enne (OOO)
Still lgtm.
7 years, 3 months ago (2013-09-13 20:58:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/23498035/1
7 years, 3 months ago (2013-09-14 00:10:23 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-14 05:04:52 UTC) #4
Message was sent while issue was closed.
Change committed as 223218

Powered by Google App Engine
This is Rietveld 408576698