Issue 23498033: Prefer jinja2 from third_party over eventual system jinja2 libraries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23498033: Prefer jinja2 from third_party over eventual system jinja2 libraries. (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 3 months ago

Reviewers:
eae

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, Nils Barth (inactive), hans

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Prefer jinja2 from third_party over eventual system jinja2 libraries. We recently added keep_trailing_newline which requires jinja2.7. The one in third_party is 2.7. See blink-dev thread: unexpected keyword argument 'keep_trailing_newline' in make_runtime_features.py https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4e6HOszrnWU BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157768

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/scripts/template_expander.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/23498033/1

7 years, 3 months ago (2013-09-13 17:14:46 UTC) #3

Message was sent while issue was closed.

Change committed as 157768