Removes uses of unnamed namespace from samplecode.

samplecode/OverView.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "OverView.h"
 
 #include "SampleCode.h"
 
 #include "SkCanvas.h"
 #include "SkView.h"
 
-namespace {
-
 const int N = 8;

[tfarina, 2013/09/10 18:14:07]

AFAIK, const has internal linkage in C++.

 const SkScalar kWidth = SkIntToScalar(640);
 const SkScalar kHeight = SkIntToScalar(480);
 const char gIsOverview[] = "is-overview";

[tfarina, 2013/09/10 00:10:18]

$ nm out/Debug/obj/samplecode/SampleApp.OverView.o | c++filt

0000000000000000 r gIsOverview

The others don't appear.

Is there another way to tell if the symbol is public or private?

[bsalomon, 2013/09/11 20:15:27]

Is that gIsOverview is treated as a ptr to a const char array and so the ptr
itself has external linkage while the thing it points to does not?

In any event, I would suggest explicitly making these static even if it is just
for documentation for the reader.

[tfarina, 2013/09/11 21:15:21]

no.

according to cdecl and the right-to-left syntax of C, this reads as:

gIsOverview is an array to const char.

if it was:

const char* gIsOverview = "...";

then that would be translated as:
gIsOverview is a pointer to const char.

No it doesn't have external linkage:

$ nm -g out/Debug/obj/samplecode/SampleApp.OverView.o | c++filt | grep
gIsOverview

-g means "Display only external symbols".

r means the symbol is in a read only data section.
Done.

 
-}  // namespace
-
 class OverView : public SkView {
 public:
     OverView(int count, const SkViewFactory* factories[]);
     virtual ~OverView();
 
 protected:
     // Overridden from SkEventSink:
     virtual bool onEvent(const SkEvent&) SK_OVERRIDE;
     virtual bool onQuery(SkEvent* evt) SK_OVERRIDE {
         if (SampleCode::TitleQ(*evt)) {
@@ skipping 74 matching lines @@
             locY += kHeight;
             locX = 0;
         }
     }
 }
 
 SkCanvas* OverView::beforeChildren(SkCanvas* canvas) {
     canvas->scale(SK_Scalar1 / N, SK_Scalar1 / N);
     return canvas;
 }