editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameClassMemberRefactoringImpl.java - Issue 23498016: Update only unique references during rename refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameClassMemberRefactoringImpl.java

Issue 23498016: Update only unique references during rename refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameLibraryRefactoringImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameClassMemberRefactoringImpl.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameClassMemberRefactoringImpl.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameClassMemberRefactoringImpl.java

index 261252e98c79a31978986f576360635046a009c9..e72931ab2461ea4849ede530353344118e71e444 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameClassMemberRefactoringImpl.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameClassMemberRefactoringImpl.java

@@ -113,14 +113,16 @@ public class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl {

}

// update references

- for (SearchMatch reference : validator.renameElementsReferences) {

+ List<SearchMatch> uniqueElementsRefs = getUniqueMatches(validator.renameElementsReferences);

+ for (SearchMatch reference : uniqueElementsRefs) {

Source refSource = reference.getElement().getSource();

SourceChange refChange = exactManager.get(refSource);

addReferenceEdit(refChange, reference);

}

// potential matches

SourceChangeManager previewManager = new SourceChangeManager();

- for (SearchMatch reference : nameReferences) {

+ List<SearchMatch> uniqueNameRefs = getUniqueMatches(nameReferences);

+ for (SearchMatch reference : uniqueNameRefs) {

Source refSource = reference.getElement().getSource();

SourceChange refChange = previewManager.get(refSource);

Edit edit = createReferenceEdit(reference, newName);