 Chromium Code Reviews
 Chromium Code Reviews Issue 23498015:
  [NaCl SDK] Support non blocking TCP/UDP  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 23498015:
  [NaCl SDK] Support non blocking TCP/UDP  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: native_client_sdk/src/libraries/nacl_io/mount_stream.h | 
| diff --git a/native_client_sdk/src/libraries/nacl_io/mount_socket.h b/native_client_sdk/src/libraries/nacl_io/mount_stream.h | 
| similarity index 64% | 
| rename from native_client_sdk/src/libraries/nacl_io/mount_socket.h | 
| rename to native_client_sdk/src/libraries/nacl_io/mount_stream.h | 
| index f235232c949bf225995c7019ede78ae6f73b7869..06446c7efbfa8463c5ed74f627655d3ff087e544 100644 | 
| --- a/native_client_sdk/src/libraries/nacl_io/mount_socket.h | 
| +++ b/native_client_sdk/src/libraries/nacl_io/mount_stream.h | 
| @@ -2,19 +2,19 @@ | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| -#ifndef LIBRARIES_NACL_IO_MOUNT_SOCKET_H_ | 
| -#define LIBRARIES_NACL_IO_MOUNT_SOCKET_H_ | 
| - | 
| -#include "nacl_io/ossocket.h" | 
| 
binji
2013/09/12 01:47:57
why removed? It is still checked in the .cc file
 
noelallen1
2013/09/12 23:19:03
There is no reason to #ifdef it out.    It will co
 | 
| -#ifdef PROVIDES_SOCKET_API | 
| +#ifndef LIBRARIES_NACL_IO_MOUNT_STREAM_H_ | 
| +#define LIBRARIES_NACL_IO_MOUNT_STREAM_H_ | 
| #include "nacl_io/mount.h" | 
| namespace nacl_io { | 
| -class MountSocket : public Mount { | 
| +// MountStreams provides a "mount point" for stream objects which do not | 
| +// provide a path, such as FDs returned by pipe, socket, and sockpair. | 
| + | 
| +class MountStream : public Mount { | 
| protected: | 
| - MountSocket(); | 
| + MountStream(); | 
| private: | 
| 
binji
2013/09/12 01:47:57
why private? MountNode defines these as public
 
noelallen1
2013/09/12 23:19:03
Done.
 | 
| virtual Error Access(const Path& path, int a_mode); | 
| @@ -28,10 +28,9 @@ class MountSocket : public Mount { | 
| private: | 
| friend class KernelProxy; | 
| - DISALLOW_COPY_AND_ASSIGN(MountSocket); | 
| + DISALLOW_COPY_AND_ASSIGN(MountStream); | 
| }; | 
| } // namespace nacl_io | 
| -#endif // PROVIDES_SOCKET_API | 
| -#endif // LIBRARIES_NACL_IO_MOUNT_SOCKET_H_ | 
| +#endif // LIBRARIES_NACL_IO_MOUNT_STREAM_H_ |