Issue 23498013: Have FontBuilder::initForStyleResolve() take a Document reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23498013: Have FontBuilder::initForStyleResolve() take a Document reference (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, dglazkov, abarth-chromium

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have FontBuilder::initForStyleResolve() take a Document reference Have FontBuilder::initForStyleResolve() take a Document reference instead of a pointer as it can never be NULL. This also avoids having to convert a reference into a pointer at the call sites. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157048

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	Source/core/css/resolver/FontBuilder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/FontBuilder.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	7 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23498013/1

7 years, 3 months ago (2013-09-01 17:55:06 UTC) #3

Message was sent while issue was closed.

Change committed as 157048

Expand Messages | Collapse Messages