Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23498004: Remove page cyclers from chrome binary. (Closed)

Created:
7 years, 3 months ago by tonyg
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Remove page cyclers from chrome binary. The page cyclers run with Telemetry now. They should not be baked into the chrome binary itself. This causes unwanted dependencies on test code and bloats the binary. BUG=280157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221201

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indent #

Patch Set 3 : rebase #

Patch Set 4 : Attempt to fix mac build #

Patch Set 5 : Another attempt to fix mac compile #

Patch Set 6 : Actually fix mac compile (tested on a mac this time) #

Patch Set 7 : Fix chrome_frame compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1238 lines) Patch
chrome/browser/chrome_browser_main.h View 1 chunk +0 lines, -5 lines 0 comments Download
chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 3 chunks +0 lines, -26 lines 0 comments Download
chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
chrome/browser/page_cycler/page_cycler.h View 1 chunk +0 lines, -154 lines 0 comments Download
chrome/browser/page_cycler/page_cycler.cc View 1 2 1 chunk +0 lines, -268 lines 0 comments Download
chrome/browser/page_cycler/page_cycler_browsertest.cc View 1 2 1 chunk +0 lines, -398 lines 0 comments Download
chrome/browser/page_cycler/page_cycler_unittest.cc View 1 2 1 chunk +0 lines, -352 lines 0 comments Download
chrome/browser/profiles/profile_impl_io_data.cc View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
chrome/chrome_browser.gypi View 1 2 3 4 5 6 3 chunks +3 lines, -8 lines 0 comments Download
chrome/chrome_tests.gypi View 1 2 3 4 5 8 chunks +7 lines, -5 lines 0 comments Download
chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 4 chunks +2 lines, -4 lines 0 comments Download
chrome/common/chrome_switches.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
chrome/common/chrome_switches.cc View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
chrome/test/perf/perf_test.gyp View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
chrome_frame/chrome_frame.gyp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
tonyg
7 years, 3 months ago (2013-08-27 05:05:22 UTC) #1
Nico
lgtm, thanks! https://codereview.chromium.org/23498004/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/23498004/diff/1/chrome/chrome_browser.gypi#newcode2463 chrome/chrome_browser.gypi:2463: # should be removed (crbug.com/279660) nit: comments ...
7 years, 3 months ago (2013-08-27 15:05:22 UTC) #2
tonyg
https://codereview.chromium.org/23498004/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/23498004/diff/1/chrome/chrome_browser.gypi#newcode2463 chrome/chrome_browser.gypi:2463: # should be removed (crbug.com/279660) On 2013/08/27 15:05:22, Nico ...
7 years, 3 months ago (2013-08-27 15:26:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23498004/9001
7 years, 3 months ago (2013-08-30 00:03:12 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-08-30 00:55:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23498004/27001
7 years, 3 months ago (2013-09-02 20:55:11 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-02 21:45:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23498004/27002
7 years, 3 months ago (2013-09-02 22:06:10 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-02 22:56:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23498004/55001
7 years, 3 months ago (2013-09-03 16:34:41 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-03 17:25:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23498004/23001
7 years, 3 months ago (2013-09-03 20:51:16 UTC) #12
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-03 20:59:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23498004/23001
7 years, 3 months ago (2013-09-03 22:15:34 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-03 23:20:52 UTC) #15
tonyg
grt@, erikwright@, I had to modify chrome_frame.gyp again. Would one of you mind taking a ...
7 years, 3 months ago (2013-09-04 00:15:21 UTC) #16
grt (UTC plus 2)
lgtm
7 years, 3 months ago (2013-09-04 03:08:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/23498004/79001
7 years, 3 months ago (2013-09-04 03:08:55 UTC) #18
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 16:50:53 UTC) #19
Message was sent while issue was closed. 
Change committed as 221201

Powered by Google App Engine
This is Rietveld 408576698