third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html - Issue 2349743003: Don't treat shorthand filters as errors on SVG content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html

Issue 2349743003: Don't treat shorthand filters as errors on SVG content (Closed)

Patch Set: Fix animation test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/animated-filter-svg-element-expected.html ('k') | third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2	2

3 <style>	3 <style>

4 svg {	4 svg {

5 width: 100px;	5 width: 100px;

6 height: 100px;	6 height: 100px;

7 margin: 1px;	7 margin: 1px;

8 }	8 }

9	9

10 #test-root {	10 #test-root {

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 <p id="test-child">	59 <p id="test-child">

60	60

61 <!-- SVG child element: the first filter is valid, the rest are not. -->	61 <!-- SVG child element: the first filter is valid, the rest are not. -->

62	62

63 <svg viewBox="0 0 50 50">	63 <svg viewBox="0 0 50 50">

64 <rect fill="red" x="0" y="0" height="50" width="50"	64 <rect fill="red" x="0" y="0" height="50" width="50"

65 style="filter: url(#filter)"/>	65 style="filter: url(#filter)"/>

66 </svg>	66 </svg>

67	67

68 <svg viewBox="0 0 50 50">	68 <svg viewBox="0 0 50 50">

69 <rect fill="red" x="0" y="0" height="50" width="50"	69 <rect fill="lime" x="0" y="0" height="50" width="50"
	pdr. 2016/09/16 18:45:17 Do we match firefox in this case? Do we match firefox in this case? fs 2016/09/16 19:02:33 Well, they support shorthand filters on SVG, so it Show quoted text On 2016/09/16 at 18:45:17, pdr. wrote: > Do we match firefox in this case? Well, they support shorthand filters on SVG, so it's kind of hard to give a definitive answer here... I guess it's more a matter of whether we want this to be lime or red. I've gone with codifying our current behavior here (which I think was the intention of this test.)
70 style="filter: url(#filter) blur(0px)"/>	70 style="filter: url(#filter) blur(0px)"/>

71 </svg>	71 </svg>

72	72

73 <svg viewBox="0 0 50 50">	73 <svg viewBox="0 0 50 50">

74 <rect fill="red" x="0" y="0" height="50" width="50"	74 <rect fill="lime" x="0" y="0" height="50" width="50"

75 style="filter: blur(0px)"/>	75 style="filter: blur(0px)"/>

76 </svg>	76 </svg>

77	77

78 <svg viewBox="0 0 50 50">	78 <svg viewBox="0 0 50 50">

79 <rect fill="red" x="0" y="0" height="50" width="50"	79 <rect fill="red" x="0" y="0" height="50" width="50"

80 style="filter: url(#missing)"/>	80 style="filter: url(#missing)"/>

81 </svg>	81 </svg>

82	82

83 <svg viewBox="0 0 50 50">	83 <svg viewBox="0 0 50 50">

84 <rect fill="red" x="0" y="0" height="50" width="50"	84 <rect fill="red" x="0" y="0" height="50" width="50"

85 style="filter: url(invalid)"/>	85 style="filter: url(invalid)"/>

86 </svg>	86 </svg>

87	87

88 <svg viewBox="0 0 50 50">	88 <svg viewBox="0 0 50 50">

89 <rect fill="red" x="0" y="0" height="50" width="50"	89 <rect fill="red" x="0" y="0" height="50" width="50"

90 style="filter: url(invalid#missing)"/>	90 style="filter: url(invalid#missing)"/>

91 </svg>	91 </svg>

92	92

93 <svg viewBox="0 0 50 50">	93 <svg viewBox="0 0 50 50">

94 <rect fill="red" x="0" y="0" height="50" width="50"	94 <rect fill="red" x="0" y="0" height="50" width="50"

95 style="filter: url(filter)"/>	95 style="filter: url(filter)"/>

96 </svg>	96 </svg>

97 </p>	97 </p>

OLD	NEW