Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2349713003: IPC::MessageFilter::OnFilterAdded: IPC::Sender -> IPC::Channel (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
Reviewers:
rjkroege, jam
CC:
avayvod+watch_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, feature-media-reviews_chromium.org, horo+watch_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jsbell+serviceworker_chromium.org, kalyank, kinuko+serviceworker, kinuko+watch, mcasas+watch+vc_chromium.org, michaeln, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, toyoshim+midi_chromium.org, tracing+reviews_chromium.org, tzik, wfh+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC::MessageFilter::OnFilterAdded: IPC::Sender -> IPC::Channel Passes an IPC::Channel* to OnFilterAdded instead of IPC::Sender*. This is changing so that filters can use more than just the Sender interface of the Channel, and namely so they can get at remote associated interfaces. BUG=612500 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e0072ebd0fa7c6b465d71ab1032f2e113c7e7695 Cr-Commit-Position: refs/heads/master@{#419329}

Patch Set 1 #

Patch Set 2 : missed a spot #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -106 lines) Patch
M chrome/renderer/media/cast_ipc_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_ipc_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/renderer/pnacl_translation_resource_host.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/pnacl_translation_resource_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/tracing/child/child_trace_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/tracing/child/child_trace_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/memory/memory_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/memory/memory_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/blob_storage/blob_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/blob_storage/blob_message_filter.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_histogram_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_histogram_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/font_cache_dispatcher_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/font_cache_dispatcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_message_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/android/synchronous_compositor_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/synchronous_compositor_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/aec_dump_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/aec_dump_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_input_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/audio_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_message_filter.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/midi_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/socket_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 4 chunks +12 lines, -12 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ipc/message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/manifest_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread_message_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/public/ozone_gpu_test_helper.cc View 3 chunks +31 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (22 generated)
Ken Rockot(use gerrit already)
An alternative solution would be to add a GetAssociatedGroup() and GetRemoteAssociatedInterface() to IPC::Sender. This CL ...
4 years, 3 months ago (2016-09-16 19:54:37 UTC) #5
Ken Rockot(use gerrit already)
On 2016/09/16 at 19:54:37, Ken Rockot wrote: > An alternative solution would be to add ...
4 years, 3 months ago (2016-09-16 19:55:23 UTC) #6
Ken Rockot(use gerrit already)
+rjkroege for ui/ozone since I added some extra gunk to FakeGpuProcess in the test support ...
4 years, 3 months ago (2016-09-16 19:57:01 UTC) #8
jam
lgtm
4 years, 3 months ago (2016-09-16 20:06:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349713003/80001
4 years, 3 months ago (2016-09-16 23:34:17 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-16 23:40:49 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 23:43:05 UTC) #29
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e0072ebd0fa7c6b465d71ab1032f2e113c7e7695
Cr-Commit-Position: refs/heads/master@{#419329}

Powered by Google App Engine
This is Rietveld 408576698