cc/trees/layer_tree_host_impl_unittest.cc - Issue 2349713002: [cc] Remove unused parameter to DidUpdateScrollOffset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 2349713002: [cc] Remove unused parameter to DidUpdateScrollOffset (Closed)

Patch Set: address reviewer comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_impl_unittest.cc

diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc

index ef465198377af77017188965bb8d348df1924e17..0201952ec6b509d32ece997a1912cbe218896ebc 100644

--- a/cc/trees/layer_tree_host_impl_unittest.cc

+++ b/cc/trees/layer_tree_host_impl_unittest.cc

@@ -486,8 +486,7 @@ class LayerTreeHostImplTest : public testing::Test,

->property_trees()

->scroll_tree.SetScrollOffsetDeltaForTesting(layer_impl->id(),

delta))

- layer_impl->layer_tree_impl()->DidUpdateScrollOffset(

- layer_impl->id(), layer_impl->transform_tree_index());

+ layer_impl->layer_tree_impl()->DidUpdateScrollOffset(layer_impl->id());

}

void BeginImplFrameAndAnimate(BeginFrameArgs begin_frame_args,

@@ -2879,8 +2878,7 @@ class LayerTreeHostImplTestScrollbarAnimation : public LayerTreeHostImplTest {

host_impl_->InnerViewportScrollLayer()->id(),

gfx::ScrollOffset(5, 5)))

host_impl_->active_tree()->DidUpdateScrollOffset(

- host_impl_->InnerViewportScrollLayer()->id(),

- host_impl_->InnerViewportScrollLayer()->transform_tree_index());

+ host_impl_->InnerViewportScrollLayer()->id());

EXPECT_FALSE(did_request_next_frame_);

EXPECT_FALSE(did_request_redraw_);

if (expecting_animations) {