[cc] Remove unused parameter to DidUpdateScrollOffset

[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out. The only real change
is in LayerTreeImpl. The other changes are just call site
updates to skip passing the 2nd parameter.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c969691b5dcba7987434cd4123763fb8804b26ff
Cr-Commit-Position: refs/heads/master@{#419177}

[Ian Vollick, 2016-09-16 14:18:28]

Description was changed from

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out.

BUG=None
==========

to

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Ian Vollick, 2016-09-16 14:18:38]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 14:18:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2016-09-16 14:19:03]

Description was changed from

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Ian Vollick, 2016-09-16 14:19:03]

vollick@chromium.org changed reviewers:
+ ajuma@chromium.org

[Ian Vollick, 2016-09-16 14:21:58]

vollick@chromium.org changed reviewers:
+ sunxd@chromium.org
- ajuma@chromium.org

[Ian Vollick, 2016-09-16 14:22:30]

Xianda, PTAL.

I ran across this while I was looking at decoupling CompositorMutableState and
layers.

[Ian Vollick, 2016-09-16 14:23:28]

Description was changed from

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out. The only real change
is in LayerTreeImpl. The other changes are just call site
updates to skip passing the 2nd parameter.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[sunxd, 2016-09-16 14:34:57]

LGTM with a suggestion on comments.

https://codereview.chromium.org/2349713002/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2349713002/diff/1/cc/trees/layer_tree_impl.cc...
cc/trees/layer_tree_impl.cc:160: transform_id =
LayerById(layer_id)->transform_tree_index();
Maybe we can move the TODO above here. As transform_id is now retrieved in the
function.

[commit-bot: I haz the power, 2016-09-16 15:04:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 15:04:34]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2016-09-16 15:09:45]

https://codereview.chromium.org/2349713002/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2349713002/diff/1/cc/trees/layer_tree_impl.cc...
cc/trees/layer_tree_impl.cc:160: transform_id =
LayerById(layer_id)->transform_tree_index();
On 2016/09/16 14:34:57, sunxd wrote:
> Maybe we can move the TODO above here. As transform_id is now retrieved in the
> function.

Done.

[Ian Vollick, 2016-09-16 15:09:48]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2016-09-16 15:09:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sunxd@chromium.org
Link to the patchset: https://codereview.chromium.org/2349713002/#ps10001
(title: "address reviewer comments.")

[commit-bot: I haz the power, 2016-09-16 15:10:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 16:03:05]

Description was changed from

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out. The only real change
is in LayerTreeImpl. The other changes are just call site
updates to skip passing the 2nd parameter.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out. The only real change
is in LayerTreeImpl. The other changes are just call site
updates to skip passing the 2nd parameter.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-16 16:03:06]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-09-16 16:04:21]

Description was changed from

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out. The only real change
is in LayerTreeImpl. The other changes are just call site
updates to skip passing the 2nd parameter.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
[cc] Remove unused parameter to DidUpdateScrollOffset

It's either reset or we early-out. The only real change
is in LayerTreeImpl. The other changes are just call site
updates to skip passing the 2nd parameter.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c969691b5dcba7987434cd4123763fb8804b26ff
Cr-Commit-Position: refs/heads/master@{#419177}
==========

[commit-bot: I haz the power, 2016-09-16 16:04:22]

Patchset 2 (id:??) landed as
https://crrev.com/c969691b5dcba7987434cd4123763fb8804b26ff
Cr-Commit-Position: refs/heads/master@{#419177}