Image Capture Linux/CrOs: wire some capabilities set/get

Image Capture Linux/CrOs: wire some capabilities set/get

This CL implements for Linux/Cros parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).

BUG=647352
Committed: https://crrev.com/f457dee66ba0bfe49b67dee35b9fb8f3ec4f17e3
Cr-Commit-Position: refs/heads/master@{#420229}

[mcasas, 2016-09-20 02:05:04]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-09-20 02:05:10]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-09-20 17:18:59]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-09-20 17:40:19]

Description was changed from

==========
Image Capture Linux/CrOs: wire zoom set/get and other (empty) capabilities

wip

BUG=647352
==========

to

==========
Image Capture Linux/CrOs: wire zoom set/get and other capabilities's get
wip

This CL implements parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).


BUG=647352
==========

[mcasas, 2016-09-20 17:41:14]

Description was changed from

==========
Image Capture Linux/CrOs: wire zoom set/get and other capabilities's get
wip

This CL implements parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).


BUG=647352
==========

to

==========
Image Capture Linux/CrOs: wire some capabilities set/get

This CL implements for Linux/Cros parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).


BUG=647352
==========

[mcasas, 2016-09-20 19:17:20]

mcasas@chromium.org changed reviewers:
+ xianglu@chromium.org

[mcasas, 2016-09-20 19:17:20]

xianglu@ PTAL

[xianglu, 2016-09-20 22:18:41]

https://codereview.chromium.org/2349693003/diff/60001/media/capture/video/lin...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2349693003/diff/60001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:348: }
What should be done if there is an error reading these control values?

https://codereview.chromium.org/2349693003/diff/60001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:402: DLOG(ERROR) << "Error
setting zoom value to " << settings->zoom;
Should it be settings->zoom / 100?

[mcasas, 2016-09-21 22:04:58]

ptal

https://codereview.chromium.org/2349693003/diff/60001/media/capture/video/lin...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2349693003/diff/60001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:348: }
On 2016/09/20 22:18:40, xianglu wrote:
> What should be done if there is an error reading these control values?

Nothing, l.340 initializes zoom_range.{minimum, 
maximum, current} all to zero, they'll only be updated
if the QUERYCTRL (l.344) and G_CTRL (l.351) succeed.

We could add a DLOG(ERROR), but we'd know 
anyway that the reading went wrong when seeing
(in JS or elsewhere) that the zoom min/max values
are 0.

https://codereview.chromium.org/2349693003/diff/60001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:402: DLOG(ERROR) << "Error
setting zoom value to " << settings->zoom;
On 2016/09/20 22:18:40, xianglu wrote:
> Should it be settings->zoom / 100?

Done.

[xianglu, 2016-09-21 23:06:11]

lgtm.

[mcasas, 2016-09-21 23:32:05]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:33:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 01:27:48]

Description was changed from

==========
Image Capture Linux/CrOs: wire some capabilities set/get

This CL implements for Linux/Cros parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).


BUG=647352
==========

to

==========
Image Capture Linux/CrOs: wire some capabilities set/get

This CL implements for Linux/Cros parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).


BUG=647352
==========

[commit-bot: I haz the power, 2016-09-22 01:27:49]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-09-22 01:29:37]

Description was changed from

==========
Image Capture Linux/CrOs: wire some capabilities set/get

This CL implements for Linux/Cros parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).


BUG=647352
==========

to

==========
Image Capture Linux/CrOs: wire some capabilities set/get

This CL implements for Linux/Cros parts of the methods:
- VideoCaptureDeviceWin::GetPhotoCapabilities():
 zoom, autofocus on/off, autoexposure on/off, and
 auto whitebalance on/off
- VideoCaptureDeviceWin::SetPhotoOptions(): zoom

and adds a small VideoCaptureDeviceTest test case
to retrieve capabilities, enabled for Linux (should be
enabled for Android in another CL).

BUG=647352

Committed: https://crrev.com/f457dee66ba0bfe49b67dee35b9fb8f3ec4f17e3
Cr-Commit-Position: refs/heads/master@{#420229}
==========

[commit-bot: I haz the power, 2016-09-22 01:29:38]

Patchset 3 (id:??) landed as
https://crrev.com/f457dee66ba0bfe49b67dee35b9fb8f3ec4f17e3
Cr-Commit-Position: refs/heads/master@{#420229}

[Henrik Grunell, 2016-09-22 06:41:56]

A revert of this CL (patchset #3 id:100001) has been created in
https://codereview.chromium.org/2364543002/ by grunell@chromium.org.

The reason for reverting is: Broken WebRTC tests

VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/0
VideoCaptureDeviceTests/VideoCaptureDeviceTest.CaptureWithSize/1
VideoCaptureDeviceTest.GetPhotoCapabilities

on

https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Tester.