Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2349683003: Fixs in perf.dart: strong-clean, avoid deprecated apis, minor output tweaks (Closed)

Created:
4 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixs in perf.dart: strong-clean, avoid deprecated apis, minor output tweaks R=brianwilkerson@google.com, paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/b9a5c7732122f3fa1a6639c3ea5bb7110275d549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M pkg/analyzer_cli/tool/perf.dart View 7 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-16 16:34:23 UTC) #4
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-16 16:35:43 UTC) #5
Paul Berry
lgtm
4 years, 3 months ago (2016-09-16 16:37:43 UTC) #6
Siggi Cherem (dart-lang)
4 years, 3 months ago (2016-09-16 16:57:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
b9a5c7732122f3fa1a6639c3ea5bb7110275d549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698