Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2349673002: Revert of bot_update: ensure correct depot_tools checkout is used. (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ ) Reason for revert: broke win_chromium_x64_rel_ng/builds/281022 because of apply_issue.bat calls local python. Original issue's description: > bot_update: ensure correct depot_tools checkout is used. > > R=vadimsh@chromium.org,martiniss@chromium.org > BUG=635641, 647446 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/972ac5040176acd90c8a1ce412f75d19f77cc4e8 TBR=martiniss@chromium.org,vadimsh@chromium.org,iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635641, 647446 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/15a248123d9032061486cd2d4b3f64369c93a9a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M recipe_modules/bot_update/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/gerrit_no_reset.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
tandrii(chromium)
Created Revert of bot_update: ensure correct depot_tools checkout is used.
4 years, 3 months ago (2016-09-16 07:47:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349673002/1
4 years, 3 months ago (2016-09-16 07:47:14 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 07:47:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/15a248123d9032...

Powered by Google App Engine
This is Rietveld 408576698