Make third_party/WebKit/Source/web/tests/DEPS a bit more strict.

Make third_party/WebKit/Source/web/tests/DEPS a bit more strict.

BUG=none

Committed: https://crrev.com/620481ed0f278ec8d2116dd94088e0eb3747e65d
Cr-Commit-Position: refs/heads/master@{#419414}

[dcheng, 2016-09-17 07:04:07]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-09-17 07:28:33]

LGTM

2016/09/17 午後4:04 <dcheng@chromium.org>:

> Reviewers: haraken
> CL: https://codereview.chromium.org/2349653003/
>
> Description:
> Make third_party/WebKit/Source/web/tests/DEPS a bit more strict.
>
> BUG=none
>
> Affected files (+14, -10 lines):
> M third_party/WebKit/Source/web/tests/DEPS
>
>
> Index: third_party/WebKit/Source/web/tests/DEPS
> diff --git a/third_party/WebKit/Source/web/tests/DEPS
> b/third_party/WebKit/Source/web/tests/DEPS
> index 36abc971579f3dd87160f54caf93dc4682d7ebeb..
> 88e5ab35e789848f15a6f2765504fa5b7c05b295 100644
> --- a/third_party/WebKit/Source/web/tests/DEPS
> +++ b/third_party/WebKit/Source/web/tests/DEPS
> @@ -1,13 +1,17 @@
> include_rules = [
> "+web/tests",
> - # For RunAllTests.cpp only.
> - "+base/bind.h",
> - "+base/bind_helpers.h",
> - "+base/run_loop.h",
> - "+base/test/launcher/unit_test_launcher.h",
> - "+base/test/test_suite.h",
> - "+base/threading/thread_task_runner_handle.h",
> - "+content/test/blink_test_environment.h",
> - "+mojo/edk/embedder/embedder.h",
> - "+mojo/public/cpp/bindings",
> ]
> +
> +specific_include_rules = {
> + 'RunAllTests\.cpp': [
> + "+base/bind.h",
> + "+base/bind_helpers.h",
> + "+base/run_loop.h",
> + "+base/test/launcher/unit_test_launcher.h",
> + "+base/test/test_suite.h",
> + "+base/threading/thread_task_runner_handle.h",
> + "+content/test/blink_test_environment.h",
> + "+mojo/edk/embedder/embedder.h",
> + "+mojo/public/cpp/bindings",
> + ],
> +}
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[haraken, 2016-09-17 07:28:34]

LGTM

2016/09/17 午後4:04 <dcheng@chromium.org>:

> Reviewers: haraken
> CL: https://codereview.chromium.org/2349653003/
>
> Description:
> Make third_party/WebKit/Source/web/tests/DEPS a bit more strict.
>
> BUG=none
>
> Affected files (+14, -10 lines):
> M third_party/WebKit/Source/web/tests/DEPS
>
>
> Index: third_party/WebKit/Source/web/tests/DEPS
> diff --git a/third_party/WebKit/Source/web/tests/DEPS
> b/third_party/WebKit/Source/web/tests/DEPS
> index 36abc971579f3dd87160f54caf93dc4682d7ebeb..
> 88e5ab35e789848f15a6f2765504fa5b7c05b295 100644
> --- a/third_party/WebKit/Source/web/tests/DEPS
> +++ b/third_party/WebKit/Source/web/tests/DEPS
> @@ -1,13 +1,17 @@
> include_rules = [
> "+web/tests",
> - # For RunAllTests.cpp only.
> - "+base/bind.h",
> - "+base/bind_helpers.h",
> - "+base/run_loop.h",
> - "+base/test/launcher/unit_test_launcher.h",
> - "+base/test/test_suite.h",
> - "+base/threading/thread_task_runner_handle.h",
> - "+content/test/blink_test_environment.h",
> - "+mojo/edk/embedder/embedder.h",
> - "+mojo/public/cpp/bindings",
> ]
> +
> +specific_include_rules = {
> + 'RunAllTests\.cpp': [
> + "+base/bind.h",
> + "+base/bind_helpers.h",
> + "+base/run_loop.h",
> + "+base/test/launcher/unit_test_launcher.h",
> + "+base/test/test_suite.h",
> + "+base/threading/thread_task_runner_handle.h",
> + "+content/test/blink_test_environment.h",
> + "+mojo/edk/embedder/embedder.h",
> + "+mojo/public/cpp/bindings",
> + ],
> +}
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dcheng, 2016-09-17 07:51:32]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-17 07:51:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 07:51:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 07:51:43]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[haraken, 2016-09-17 08:14:25]

LGTM (from a correct account)

[haraken, 2016-09-17 08:14:34]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-09-17 08:14:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 10:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 10:27:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-09-17 19:33:17]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-17 19:33:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 20:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 20:45:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-09-17 21:01:01]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-17 21:01:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 23:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 23:20:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-09-17 23:23:44]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-17 23:23:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 01:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 01:36:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-09-18 02:30:27]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-18 02:30:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 04:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 04:39:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-09-18 16:35:12]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-18 16:35:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 18:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 18:50:30]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-09-18 22:09:23]

PTAL

https://codereview.chromium.org/2349653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/DEPS (right):

https://codereview.chromium.org/2349653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/DEPS:2: "+mojo/public/cpp/bindings",
ScreenWakeLockTest.cpp is already using the mojo bindings in the tests. I think
this should be OK?

[dcheng, 2016-09-18 22:09:28]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-18 22:09:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 23:16:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 23:16:33]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-09-19 03:34:54]

LGTM

[dcheng, 2016-09-19 05:35:02]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-09-19 05:35:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 05:39:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-19 05:41:38]

Description was changed from

==========
Make third_party/WebKit/Source/web/tests/DEPS a bit more strict.

BUG=none
==========

to

==========
Make third_party/WebKit/Source/web/tests/DEPS a bit more strict.

BUG=none

Committed: https://crrev.com/620481ed0f278ec8d2116dd94088e0eb3747e65d
Cr-Commit-Position: refs/heads/master@{#419414}
==========

[commit-bot: I haz the power, 2016-09-19 05:41:39]

Patchset 2 (id:??) landed as
https://crrev.com/620481ed0f278ec8d2116dd94088e0eb3747e65d
Cr-Commit-Position: refs/heads/master@{#419414}