third_party/WebKit/Source/core/dom/Element.h - Issue 2349653002: Added support of getClientRects() for SVG Elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2349653002: Added support of getClientRects() for SVG Elements. (Closed)

Patch Set: Align with review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.h

diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h

index 230db07ebf4207b3f5d9eb87259610eed5dd85a1..303639c2197bbf6ba4645320dfd2ba1555e502de 100644

--- a/third_party/WebKit/Source/core/dom/Element.h

+++ b/third_party/WebKit/Source/core/dom/Element.h

@@ -715,6 +715,8 @@ private:

void updateId(TreeScope&, const AtomicString& oldId, const AtomicString& newId);

void updateName(const AtomicString& oldName, const AtomicString& newName);

+ void clientQuads(Vector<FloatQuad>& quads);

fs 2016/09/29 12:04:21 Nit: Could this be const?

Shanmuga Pandi 2016/09/29 13:14:13 Adding const will give build break due to document

fs 2016/09/29 13:16:09 I almost expected that would be the case. Thanks.

NodeType getNodeType() const final;

bool childTypeAllowed(NodeType) const final;