Added support of getClientRects() for SVG Elements.

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1016 matching lines @@
     // TODO(tkent): Can we check invisibility by scrollable non-frame elements?
 
     IntSize viewportSize = document().page()->frameHost().visualViewport().size();
     IntRect rect(0, 0, viewportSize.width(), viewportSize.height());
     // We don't use absoluteBoundingBoxRect() because it can return an IntRect
     // larger the actual size by 1px. crbug.com/470503
     rect.intersect(document().view()->contentsToViewport(roundedIntRect(layoutObject()->absoluteBoundingBoxFloatRect())));
     return rect;
 }
 
+void Element::clientQuads(Vector<FloatQuad>& quads)
+{
+    document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+
+    LayoutObject* elementLayoutObject = layoutObject();
+    if (!elementLayoutObject)
+        return;
+
+    if (isSVGElement() && !elementLayoutObject->isSVGRoot()) {
+        // Get the bounding rectangle from the SVG model.
+        if (toSVGElement(this)->isSVGGraphicsElement())
+            quads.append(elementLayoutObject->localToAbsoluteQuad(elementLayoutObject->objectBoundingBox()));
+    } else if (elementLayoutObject->isBoxModelObject() || elementLayoutObject->isBR()) {

[fs, 2016/09/29 12:04:21]

Nit: While we're shuffling code, we could consider doing something like:

if (<condition>) {
    // Do stuff
    return;
}
if (<next condition>) {
    ...
}

i.e get rid of the 'else' branch.

[Shanmuga Pandi, 2016/09/29 13:14:13]

Done.

+        elementLayoutObject->absoluteQuads(quads);
+    }
+}
+
 ClientRectList* Element::getClientRects()
 {
-    document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+    Vector<FloatQuad> quads;
+    clientQuads(quads);
+    if (quads.isEmpty())
+        return ClientRectList::create();
+
+    // FIXME: Handle table/inline-table with a caption.

[fs, 2016/09/29 12:04:21]

Nit: I guess this comment might be better suited for clientQuads now.

[Shanmuga Pandi, 2016/09/29 13:14:12]

Done.

 
     LayoutObject* elementLayoutObject = layoutObject();
-    if (!elementLayoutObject || (!elementLayoutObject->isBoxModelObject() && !elementLayoutObject->isBR()))
-        return ClientRectList::create();
-
-    // FIXME: Handle SVG elements.
-    // FIXME: Handle table/inline-table with a caption.
-
-    Vector<FloatQuad> quads;
-    elementLayoutObject->absoluteQuads(quads);
+    DCHECK(elementLayoutObject);
     document().adjustFloatQuadsForScrollAndAbsoluteZoom(quads, *elementLayoutObject);
     return ClientRectList::create(quads);
 }
 
 ClientRect* Element::getBoundingClientRect()
 {
-    document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
-
     Vector<FloatQuad> quads;
-    LayoutObject* elementLayoutObject = layoutObject();
-    if (elementLayoutObject) {
-        if (isSVGElement() && !elementLayoutObject->isSVGRoot()) {
-            // Get the bounding rectangle from the SVG model.
-            if (toSVGElement(this)->isSVGGraphicsElement())
-                quads.append(elementLayoutObject->localToAbsoluteQuad(elementLayoutObject->objectBoundingBox()));
-        } else if (elementLayoutObject->isBoxModelObject() || elementLayoutObject->isBR()) {
-            elementLayoutObject->absoluteQuads(quads);
-        }
-    }
-
+    clientQuads(quads);
     if (quads.isEmpty())
         return ClientRect::create();
 
     FloatRect result = quads[0].boundingBox();
     for (size_t i = 1; i < quads.size(); ++i)
         result.unite(quads[i].boundingBox());
 
+    LayoutObject* elementLayoutObject = layoutObject();
     DCHECK(elementLayoutObject);
     document().adjustFloatRectForScrollAndAbsoluteZoom(result, *elementLayoutObject);
     return ClientRect::create(result);
 }
 
 const AtomicString& Element::computedRole()
 {
     document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
     std::unique_ptr<ScopedAXObjectCache> cache = ScopedAXObjectCache::create(document());
     return cache->get()->computedRoleForNode(this);
@@ skipping 2742 matching lines @@
 
 DEFINE_TRACE_WRAPPERS(Element)
 {
     if (hasRareData()) {
         visitor->traceWrappers(elementRareData());
     }
     ContainerNode::traceWrappers(visitor);
 }
 
 } // namespace blink