Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2349643002: Fix failed to import bookmarks from firefox (Closed)

Created:
4 years, 3 months ago by darkdh
Modified:
3 years, 11 months ago
Reviewers:
gab, Ilya Sherman
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix failed to import bookmarks from firefox BUG=638977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/utility/importer/firefox_importer.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
darkdh
4 years, 3 months ago (2016-09-16 05:59:05 UTC) #3
gab
There is already an upcoming CL to fix this issue :-( : https://codereview.chromium.org/2296633002/. isherman@ is ...
4 years, 3 months ago (2016-09-16 19:51:16 UTC) #5
Ilya Sherman
Hi, thanks for the contribution! I think the approach in https://codereview.chromium.org/2296633002/ is more comprehensive, and ...
4 years, 2 months ago (2016-09-27 01:40:59 UTC) #6
gab
3 years, 11 months ago (2017-01-10 19:21:55 UTC) #7
Message was sent while issue was closed.
On 2016/09/27 01:40:59, Ilya Sherman wrote:
> Hi, thanks for the contribution!  I think the approach in
> https://codereview.chromium.org/2296633002/ is more comprehensive, and so will
> probably be the better path forward.  Please do feel free to chime in with
your
> thoughts on that code review, if you'd like to! =)

That other CL landed, closing this, thanks!

Powered by Google App Engine
This is Rietveld 408576698