gyp performance: don't invoke python to check dir existance

gyp performance: don't invoke python to check dir existance

We spend a few tenths of a second every gyp invocation starting
the dir_exists.py program. Seems a bit unnecessary.

BUG=362075
R=scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264316

[Daniel Bratell, 2014-04-11 14:05:02]

dir_exists.py was invoked a few dozen times during a gyp generation and the
overhead of starting python and using the subprocess APIs were noticeable

[scottmg, 2014-04-11 14:35:39]

https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py
File build/dir_exists.py (right):

https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py#newcode18
build/dir_exists.py:18: """Hook to be called from gyp withing starting a
separate python
withing -> when

[scottmg, 2014-04-11 14:35:43]

lgtm

[Jens Widell, 2014-04-11 14:37:22]

On 2014/04/11 14:35:39, scottmg wrote:
> https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py
> File build/dir_exists.py (right):
> 
> https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py#newcode18
> build/dir_exists.py:18: """Hook to be called from gyp withing starting a
> separate python
> withing -> when

Or rather "without", perhaps?

[scottmg, 2014-04-11 17:12:34]

On 2014/04/11 14:37:22, Jens Lindström wrote:
> On 2014/04/11 14:35:39, scottmg wrote:
> > https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py
> > File build/dir_exists.py (right):
> > 
> >
https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py#newcode18
> > build/dir_exists.py:18: """Hook to be called from gyp withing starting a
> > separate python
> > withing -> when
> 
> Or rather "without", perhaps?

Oops, indeed.

[Daniel Bratell, 2014-04-14 12:21:12]

https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py
File build/dir_exists.py (right):

https://codereview.chromium.org/234963003/diff/1/build/dir_exists.py#newcode18
build/dir_exists.py:18: """Hook to be called from gyp withing starting a
separate python
On 2014/04/11 14:35:40, scottmg wrote:
> withing -> when

Done "withing" -> "without".

[Daniel Bratell, 2014-04-16 16:53:46]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-04-16 16:54:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/234963003/20001

[commit-bot: I haz the power, 2014-04-16 17:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-16 17:40:11]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Daniel Bratell, 2014-04-16 17:53:36]

I need a nod from one of the owners of content/content.gyp too.

brettw, could you please take a look?

[brettw, 2014-04-16 18:11:29]

lgtm

[Daniel Bratell, 2014-04-16 19:28:24]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-04-16 19:29:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bratell@opera.com/234963003/20001

[commit-bot: I haz the power, 2014-04-16 21:52:53]

Change committed as 264316